Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manually create flytekit/_version.py file in docs build #4556

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

cosmicBboy
Copy link
Contributor

This PR fixes a breakage in the monodocs build introduced by flyteorg/flytekit@f0d4f13, where a _version.py file is being created in the package build process.

Verified

This commit was signed with the committer’s verified signature.
cosmicBboy Niels Bantilan
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c6a7653) 58.92% compared to head (e052a3b) 58.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4556   +/-   ##
=======================================
  Coverage   58.92%   58.92%           
=======================================
  Files         620      620           
  Lines       52432    52432           
=======================================
  Hits        30896    30896           
  Misses      19071    19071           
  Partials     2465     2465           
Flag Coverage Δ
unittests 58.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -33,6 +33,11 @@ class Project:


def update_sys_path_for_flytekit(import_project_config: ImportProjectsConfig):
# create flytekit/_version.py file manually
with open(f"{import_project_config.flytekit_api_dir}/flytekit/_version.py", "w") as f:
f.write(f'__version__ = "dev"')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little hacky, but it'll work for our use case. For tagged releases, the version will end up being the actual tagged version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will think on this more, there's probably a more principled way of doing this

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 8, 2023
@cosmicBboy cosmicBboy merged commit e221f9f into master Dec 8, 2023
41 checks passed
@cosmicBboy cosmicBboy deleted the fix-monodocs branch December 8, 2023 18:20
pvditt pushed a commit that referenced this pull request Dec 13, 2023
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants