Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for onboarding docs revamp #4548

Merged
merged 6 commits into from
Jan 25, 2024
Merged

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Dec 7, 2023

Why are the changes needed?

This PR adds changes needed in Flyte for the onboarding docs revamp project. The majority of changes are in Flytesnacks, but a few changes are needed in this repo.

What changes were proposed in this pull request?

  • Updated the toctree in docs/index.md to add the new "Getting started with workflow development" section
  • Updated docs/introduction.md with new content

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

flyteorg/flytesnacks#1266

Docs link

TBD

@neverett neverett added the documentation Improvements or additions to documentation label Dec 7, 2023
@neverett neverett self-assigned this Dec 7, 2023
@neverett neverett changed the title Updates for onboarding docs revamp Updates for onboarding docs revamp (old docs and monodocs) Dec 8, 2023
@neverett neverett marked this pull request as ready for review January 9, 2024 20:49
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 9, 2024
@neverett neverett requested a review from ppiegaze January 9, 2024 20:49
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bcb7abe) 58.33% compared to head (4dd7106) 58.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4548   +/-   ##
=======================================
  Coverage   58.33%   58.33%           
=======================================
  Files         626      626           
  Lines       53938    53938           
=======================================
+ Hits        31465    31466    +1     
+ Misses      19949    19948    -1     
  Partials     2524     2524           
Flag Coverage Δ
unittests 58.33% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neverett neverett changed the title Updates for onboarding docs revamp (old docs and monodocs) Updates for onboarding docs revamp Jan 25, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 25, 2024
@neverett neverett merged commit 42d3866 into master Jan 25, 2024
44 of 45 checks passed
@neverett neverett deleted the nikki-onboarding-docs-revamp branch January 25, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants