-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for onboarding docs revamp #4548
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikki everett <[email protected]>
9 tasks
neverett
changed the title
Updates for onboarding docs revamp
Updates for onboarding docs revamp (old docs and monodocs)
Dec 8, 2023
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Jan 9, 2024
Signed-off-by: nikki everett <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4548 +/- ##
=======================================
Coverage 58.33% 58.33%
=======================================
Files 626 626
Lines 53938 53938
=======================================
+ Hits 31465 31466 +1
+ Misses 19949 19948 -1
Partials 2524 2524
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
neverett
changed the title
Updates for onboarding docs revamp (old docs and monodocs)
Updates for onboarding docs revamp
Jan 25, 2024
ppiegaze
approved these changes
Jan 25, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This PR adds changes needed in Flyte for the onboarding docs revamp project. The majority of changes are in Flytesnacks, but a few changes are needed in this repo.
What changes were proposed in this pull request?
toctree
in docs/index.md to add the new "Getting started with workflow development" sectionCheck all the applicable boxes
Related PRs
flyteorg/flytesnacks#1266
Docs link
TBD