Fix flaky test_monitor #4537
Merged
Fix flaky test_monitor #4537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
dosubot
bot
added
the
size:XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4537 +/- ##
=======================================
Coverage 58.91% 58.91%
=======================================
Files 620 620
Lines 52432 52432
=======================================
+ Hits 30889 30892 +3
+ Misses 19078 19074 -4
- Partials 2465 2466 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eapolinario
approved these changes
Dec 6, 2023
pvditt
pushed a commit
that referenced
this pull request
Dec 13, 2023
* Fix flaky test_monitor Signed-off-by: Kevin Su <[email protected]> * fix test Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Paul Dittamo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Test_monitor sometimes fails due to this error.
This error occurs because we try to call
wg.Doneafter WaitGroup counter become 0.What changes were proposed in this pull request?
This PR fixes this flaky test by stopping syncing item in the autoRefreshCache once WaitGroup counter become 0.
How was this patch tested?
Run this unit test
Check all the applicable boxes