Detect subNode phase updates to reduce evaluation frequency of ArrayNode #4535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on ArrayNode state Signed-off-by: Daniel Rammer <[email protected]>
dosubot
bot
added
the
size:S
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4535 +/- ##
=======================================
Coverage 58.92% 58.92%
=======================================
Files 620 620
Lines 52432 52441 +9
=======================================
+ Hits 30896 30903 +7
- Misses 19071 19073 +2
Partials 2465 2465
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…atency Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
…atency Signed-off-by: Daniel Rammer <[email protected]>
pvditt
approved these changes
Dec 8, 2023
…atency Signed-off-by: Daniel Rammer <[email protected]>
Great call out. Will add in next PR for parallelizing evaluations in ArrayNode. |
3 tasks
pvditt
pushed a commit
that referenced
this pull request
Dec 13, 2023
…ode (#4535) * detecting subNode or task phase updates to increment TaskPhaseVersion on ArrayNode state Signed-off-by: Daniel Rammer <[email protected]> * not writting empty file on no inputs Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Paul Dittamo <[email protected]>
eapolinario
added a commit
that referenced
this pull request
Dec 18, 2023
…f ArrayNode (#4535)" This reverts commit b50ba87. Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
added a commit
that referenced
this pull request
Dec 20, 2023
* Revert "Detect subNode phase updates to reduce evaluation frequency of ArrayNode (#4535)" This reverts commit b50ba87. Signed-off-by: Eduardo Apolinario <[email protected]> * Add flyin pflags Signed-off-by: Eduardo Apolinario <[email protected]> * Add taskTemplate as parameter to GetLogsForContainerInPod Signed-off-by: Eduardo Apolinario <[email protected]> * Add flyin template scheme and unit tests Signed-off-by: Eduardo Apolinario <[email protected]> * Revert unintended change. Signed-off-by: Eduardo Apolinario <[email protected]> * Lint Signed-off-by: Eduardo Apolinario <[email protected]> * Fix bad refactor due to lint warning Signed-off-by: Eduardo Apolinario <[email protected]> * Remove TODOs Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
Reduces the frequency of eventing and CRD updates to improve performance.
What changes were proposed in this pull request?
Rather than incrementing the
TaskPhaseVersionon theArrayNodeStateduring every loop we detect if any of the subNode phases or task phases have changed. If so, we increment theTaskPhaseVersion. This vastly reduces the frequency with whichArrayNodesare evaluated, therefore improving performance on large concurrency executions.How was this patch tested?
Locally with pprof and otel.
Setup process
NA
Screenshots
NA
Check all the applicable boxes
Related PRs
NA
Docs link
NA