Removed composition error from branch node #4528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <[email protected]>
dosubot
bot
added
the
size:M
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4528 +/- ##
==========================================
+ Coverage 58.90% 60.06% +1.16%
==========================================
Files 620 440 -180
Lines 52458 36110 -16348
==========================================
- Hits 30901 21691 -9210
+ Misses 19090 12691 -6399
+ Partials 2467 1728 -739
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Dec 5, 2023
pvditt
pushed a commit
that referenced
this pull request
Dec 13, 2023
Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Paul Dittamo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
fixes #4483
Why are the changes needed?
Propeller is no longer parsing composition structs correctly.
What changes were proposed in this pull request?
Removed the
Errorcomposition wrapper overflyteidl...core.Error.How was this patch tested?
Unit tests updated and local testing.
Setup process
NA
Screenshots
_NA)
Check all the applicable boxes
Related PRs
NA
Docs link
NA