Update pyflyte serve into pyflyte serve agent #4526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chao-Heng Lee <[email protected]>
dosubot
bot
added
the
size:XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4526 +/- ##
=======================================
Coverage 59.02% 59.02%
=======================================
Files 643 643
Lines 55153 55153
=======================================
+ Hits 32552 32555 +3
+ Misses 20020 20018 -2
+ Partials 2581 2580 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Conflicts: # deployment/agent/flyte_agent_helm_generated.yaml
EngHabu
previously approved these changes
Jan 23, 2024
…e-pyflyte-serve-agent-command Signed-off-by: Future-Outlier <[email protected]>
|
I've built an image to test this PR.
|
Signed-off-by: Future-Outlier <[email protected]>
dosubot
bot
added
size:S
Future-Outlier
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#3936
Why are the changes needed?
Because of updating the cli for agent in flyteorg/flytekit#2019 , we have to update the helm chart to fit the changes.
What changes were proposed in this pull request?
Updating
pyflyte serveintopyflyte serve agent.Check all the applicable boxes
Related PRs
flyteorg/flytekit#2019