-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix databricks plugin #4206
Fix databricks plugin #4206
Conversation
Signed-off-by: Kevin Su <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4206 +/- ##
==========================================
+ Coverage 58.95% 59.36% +0.40%
==========================================
Files 621 552 -69
Lines 52932 39905 -13027
==========================================
- Hits 31206 23688 -7518
+ Misses 19229 13884 -5345
+ Partials 2497 2333 -164
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the problems we've seen when testing the plugin.
--------- Signed-off-by: Kevin Su <[email protected]> Signed-off-by: squiishyy <[email protected]>
Tracking issue
The databricks plugin does not check for all possible terminal states as returned from the Databricks Jobs API. As a result, if the Databricks jobs API returns a state which the plugin is not written to recognise, the plugin will think that the job is still in a running phase.
#4243
Describe your changes
Transition task status to
Failure
if the lifeCycleState isSKIPPED
orINTERNAL_ERROR
Check all the applicable boxes
Screenshots
Note to reviewers