Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monorepo] Bump flyteplugins to v1.1.32 #4124

Closed
wants to merge 2 commits into from

Conversation

eapolinario
Copy link
Contributor

@eapolinario eapolinario commented Oct 3, 2023

Describe your changes

This PR brings flyteorg/flyteplugins#403 to the monorepo. Notice that flytepropeller unit tests are failing with (and possibly other failures):

go test ./... -race -coverprofile=coverage.txt -covermode=atomic
# github.com/flyteorg/flyte/flytepropeller/pkg/controller/nodes/task
Error: pkg/controller/nodes/task/taskexec_context.go:134:9: cannot use t.tm (variable of type taskExecutionMetadata) as type "github.com/flyteorg/flyte/flyteplugins/go/tasks/pluginmachinery/core".TaskExecutionMetadata in return statement:
	taskExecutionMetadata does not implement "github.com/flyteorg/flyte/flyteplugins/go/tasks/pluginmachinery/core".TaskExecutionMetadata (wrong type for GetInterruptibleFailureThreshold method)
		have GetInterruptibleFailureThreshold() uint32
		want GetInterruptibleFailureThreshold() int32

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b35cc95) 58.98% compared to head (ae782e5) 61.41%.
Report is 7 commits behind head on master.

❗ Current head ae782e5 differs from pull request most recent head 0a20a0b. Consider uploading reports for the commit 0a20a0b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4124      +/-   ##
==========================================
+ Coverage   58.98%   61.41%   +2.43%     
==========================================
  Files         618      372     -246     
  Lines       52708    26643   -26065     
==========================================
- Hits        31088    16362   -14726     
+ Misses      19140     8675   -10465     
+ Partials     2480     1606     -874     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...go/tasks/plugins/array/k8s/subtask_exec_context.go 83.18% <100.00%> (+1.36%) ⬆️

... and 579 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario
Copy link
Contributor Author

Closed in favor of #4153.

@eapolinario eapolinario closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants