Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spotify to Current Usage #372

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Add Spotify to Current Usage #372

merged 1 commit into from
Jun 29, 2020

Conversation

narape
Copy link
Collaborator

@narape narape commented Jun 29, 2020

No description provided.

@honnix
Copy link
Member

honnix commented Jun 29, 2020

@kumare3 Please feel free to merge.

@kumare3 kumare3 merged commit c04cdbe into flyteorg:master Jun 29, 2020
@narape narape deleted the patch-1 branch June 30, 2020 06:25
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Dec 6, 2022
* Added ci check for go generate

Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>

Co-authored-by: Katrina Rogan <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Dec 6, 2022
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Jul 24, 2023
…lyteorg#372)

* Refactor task log templates to support extra vars

* plumbing for k8s

* Cleanup use of providers

* cleanup

* more cleanups

* more cleanups

* more cleanups

* Plumb through task context for plugins

* fix

Signed-off-by: Jeev B <[email protected]>

* move task execution identifier into Input struct

* use pointer

* tests

Signed-off-by: Jeev B <[email protected]>

* fix linting

Signed-off-by: Jeev B <[email protected]>

* cleanups

* fix

* revert to using regex replacements for performance

* Readd benchmark

* Split templating scheme (flyteorg#373)

* Use a split templating scheme

* add enum for TemplateScheme

* cleanup comment

* fix linting issues

* add unit tests for templateVarsForScheme

* update for consistency

---------

Signed-off-by: Jeev B <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Aug 9, 2023
* Added ci check for go generate

Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>

Co-authored-by: Katrina Rogan <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Aug 21, 2023
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Aug 21, 2023
…lyteorg#372)

* Refactor task log templates to support extra vars

* plumbing for k8s

* Cleanup use of providers

* cleanup

* more cleanups

* more cleanups

* more cleanups

* Plumb through task context for plugins

* fix

Signed-off-by: Jeev B <[email protected]>

* move task execution identifier into Input struct

* use pointer

* tests

Signed-off-by: Jeev B <[email protected]>

* fix linting

Signed-off-by: Jeev B <[email protected]>

* cleanups

* fix

* revert to using regex replacements for performance

* Readd benchmark

* Split templating scheme (flyteorg#373)

* Use a split templating scheme

* add enum for TemplateScheme

* cleanup comment

* fix linting issues

* add unit tests for templateVarsForScheme

* update for consistency

---------

Signed-off-by: Jeev B <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants