-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase default project quota in the sandbox and demo #3061
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
bcf9923
update default quota in the sandbox and demo
pingsutw 00a3b21
Make helm
pingsutw 8cd2e3e
wip
pingsutw 173c409
make helm
pingsutw 3d3881f
Update resource
pingsutw 374b73d
update
pingsutw 7741afe
Merge branch 'master' of github.com:flyteorg/flyte into update-quota
pingsutw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,6 +49,19 @@ configmap: | |
CONFIG_DIR: /etc/flyte/config | ||
DISABLE_AUTH: "1" | ||
|
||
# -- Task default resources configuration | ||
# Refer to the full [structure](https://pkg.go.dev/github.com/lyft/[email protected]/pkg/runtime/interfaces#TaskResourceConfiguration). | ||
task_resource_defaults: | ||
# -- Task default resources parameters | ||
task_resources: | ||
defaults: | ||
cpu: 500m | ||
memory: 1Gi | ||
limits: | ||
cpu: 2 | ||
memory: 4Gi | ||
gpu: 5 | ||
|
||
|
||
# -- Kubernetes specific Flyte configuration | ||
k8s: | ||
|
@@ -102,3 +115,64 @@ redis: | |
# --- enable or disable Redis Statefulset installation | ||
enabled: false | ||
|
||
# -- Configuration for the Cluster resource manager component. This is an optional component, that enables automatic | ||
# cluster configuration. This is useful to set default quotas, manage namespaces etc that map to a project/domain | ||
cluster_resource_manager: | ||
# -- Enables the Cluster resource manager component | ||
enabled: true | ||
standaloneDeployment: false | ||
# -- Service account name to run with | ||
service_account_name: flyteadmin | ||
# -- Annotations for ClusterResource pods | ||
podAnnotations: {} | ||
# -- Configmap for ClusterResource parameters | ||
config: | ||
# -- ClusterResource parameters | ||
# Refer to the [structure](https://pkg.go.dev/github.com/lyft/[email protected]/pkg/runtime/interfaces#ClusterResourceConfig) to customize. | ||
cluster_resources: | ||
# -- How frequently to run the sync process | ||
refreshInterval: 5m | ||
templatePath: "/etc/flyte/clusterresource/templates" | ||
# -- Starts the cluster resource manager in standalone mode with requisite auth credentials to call flyteadmin service endpoints | ||
standaloneDeployment: false | ||
customData: | ||
- production: | ||
- projectQuotaCpu: | ||
value: "8" | ||
- projectQuotaMemory: | ||
value: "16Gi" | ||
- staging: | ||
- projectQuotaCpu: | ||
value: "8" | ||
- projectQuotaMemory: | ||
value: "16Gi" | ||
- development: | ||
- projectQuotaCpu: | ||
value: "8" | ||
- projectQuotaMemory: | ||
value: "16Gi" | ||
|
||
# -- Resource templates that should be applied | ||
templates: | ||
# -- Template for namespaces resources | ||
- key: aa_namespace | ||
value: | | ||
apiVersion: v1 | ||
kind: Namespace | ||
metadata: | ||
name: {{ namespace }} | ||
spec: | ||
finalizers: | ||
- kubernetes | ||
- key: ab_project_resource_quota | ||
value: | | ||
apiVersion: v1 | ||
kind: ResourceQuota | ||
metadata: | ||
name: project-quota | ||
namespace: {{ namespace }} | ||
spec: | ||
hard: | ||
limits.cpu: {{ projectQuotaCpu }} | ||
limits.memory: {{ projectQuotaMemory }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, If we don't add it, the sandbox will use the default config in value.yaml
I rebuilt the sandbox image and ran the command
flytectl sandbox start --image pingsutw/sandbox-test
to create cluster. Then check if the resource is updated in the configmap.