Use the same pod annotation formatting in syncresources cronjob

[bstadlbauer]

The pod annotations for flyteadmin and clusterresourcesync are inconsistent in the flyte-core helm chart.

Flyteadmin:

  template:
    metadata:
      annotations:
        configChecksum: {{ include (print .Template.BasePath "/admin/configmap.yaml") . | sha256sum | trunc 63 | quote }}
        {{- with .Values.flyteadmin.podAnnotations }}
        {{- toYaml . | nindent 8 }}
        {{- end }}

Clusterresourcesync:

      template:
        {{- with .Values.flyteadmin.podAnnotations }}
        metadata:
          annotations: {{ tpl (toYaml .) $ | nindent 12 }}
        {{- end }}

Note that one will try to complete the template, whereas the other will not.
So with annotations defined as:

  flyteadmin:
    podAnnotations:
      vault.hashicorp.com/agent-inject-template-flyte-admin-database: |
        {{- with secret "secret/flyte/admin/database" -}}
          {{- .Data.data.PASSWORD }}
        {{- end }}

The outcome would be different on the two pods.

This PR would align the formatting to be the same in both (just "print" the values as is)

[yindia]

small change, Add annotations if they are passed or else don't specify them in generated template.

        metadata:
          {{- with .Values.flyteadmin.podAnnotations }}
          annotations:
            {{- toYaml . | nindent 12 }}
          {{- end }}

[bstadlbauer]

I've updated this 👍

[bstadlbauer]

@evalsocket Thanks again for the quick review! I've updated the chart according to your review and have re-run make-helm in 0da6370

[yindia]

Awesome

[welcome]

Congrats on merging your first pull request! 🎉

[bstadlbauer]

@evalsocket - Would it be possible to release these changes? I've checked the v1.0.1 helm chart of flyte-core but it seems that these did not make it in yet

[yindia]

@bstadlbauer We only release chart with flyte release(In flyte App version is same as chart version).

@EngHabu @eapolinario Is it ok to create a beta release ?

[EngHabu]

Yes please go ahead!

[EngHabu]

1.0.2-b1

[agates4]

Hey @evalsocket, would love to see the beta release ~
Just confirming, would this change also be in that release? #2438

[yindia]

@agates4 yes

[bstadlbauer]

@evalsocket Is there an ETA for the beta release?

[yindia]

@bstadlbauer We created a beta release https://github.com/flyteorg/flyte/releases/tag/v1.0.2-b1, Please check and let us know if anything missing

[bstadlbauer]

@evalsocket Thank you for the release! We did run into an issue when adding podAnnotations to syncresources, I've opened up a PR here: #2542