Add backward compatibility checks for api changes #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunk
reviewed
Feb 3, 2022
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
EngHabu
force-pushed
the
back-compat-api
branch
from
35450d6 to
d3396a3
Compare
wild-endeavor
previously approved these changes
Feb 4, 2022
| @@ -24,7 +24,10 @@ jobs: | |||
| end-to-end-kustomize: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: actions/checkout@v1 | |||
| - uses: actions/checkout@v2 | |||
| - uses: actions/setup-go@v2 | |||
There was a problem hiding this comment.
why did we not need go before?
There was a problem hiding this comment.
This is in my attempt to keep the environment consistent for make helm in CI and locally until we introduce a docker image to build helm template :-))))
| @@ -21,4 +26,7 @@ spec: | |||
| type: object | |||
| x-kubernetes-preserve-unknown-fields: true | |||
| properties: | |||
| {{- else }} | |||
| version: v1alpha1 | |||
There was a problem hiding this comment.
should this be plural? or the one above singular?
There was a problem hiding this comment.
This is the deprecated form.. you could only have one... the new api allows multiple versions declared in the CRD...
script/generate_helm.sh
Outdated
| @@ -38,7 +39,7 @@ if [ -n "$DELTA_CHECK" ]; then | |||
| echo "diff detected: $DIFF" | |||
| DIFF=$(git diff --name-only) | |||
| echo "files different: $DIFF" | |||
| exit 1 | |||
| exit 0 | |||
There was a problem hiding this comment.
Ops... nooo... that was me playing with the script... thanks for catching this!
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
wild-endeavor
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described here. The work done to move to the latest K8s APIs would break backward compatibility with older clusters. This PR adds compatibility check to use the corresponding K8s APIs
Signed-off-by: Haytham Abuelfutuh [email protected]