-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kustomize update #1805
Kustomize update #1805
Conversation
update apiVersion according to https://kubernetes.io/docs/reference/using-api/deprecation-guide/
update apiVersion according to https://kubernetes.io/docs/reference/using-api/deprecation-guide/
update apiVersion according to https://kubernetes.io/docs/reference/using-api/deprecation-guide/
Thank you for opening this pull request! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these changes backward compatible? will applying the new manifests on an existing deployment break or duplicate the objects?
kustomize/base/wf_crd/wf_crd.yaml
Outdated
properties: | ||
cronSpec: | ||
type: string | ||
image: | ||
type: string | ||
replicas: | ||
type: integer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have these properties on the object... this can be left empty. right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not quite familiar with this part. However, if we don't include anything in the schema, it still broke. That's why we included an empty schema. If you think this can be left empty, please go ahead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this worked for me:
versions:
- name: v1alpha1
schema:
openAPIV3Schema:
description: 'FlyteWorkflow: represents one Execution Workflow object'
type: object
served: true
storage: true
kustomize/base/wf_crd/wf_crd.yaml
Outdated
versions: | ||
- name: v1alpha1 | ||
served: true | ||
storage: true | ||
schema: | ||
openAPIV3Schema: | ||
type: object | ||
properties: | ||
spec: | ||
type: object | ||
properties: | ||
cronSpec: | ||
type: string | ||
image: | ||
type: string | ||
replicas: | ||
type: integer | ||
# either Namespaced or Cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked for me
versions: | |
- name: v1alpha1 | |
served: true | |
storage: true | |
schema: | |
openAPIV3Schema: | |
type: object | |
properties: | |
spec: | |
type: object | |
properties: | |
cronSpec: | |
type: string | |
image: | |
type: string | |
replicas: | |
type: integer | |
# either Namespaced or Cluster | |
versions: | |
- name: v1alpha1 | |
schema: | |
openAPIV3Schema: | |
description: 'FlyteWorkflow: represents one Execution Workflow object' | |
type: object | |
served: true | |
storage: true | |
# either Namespaced or Cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @EngHabu , i tested in my laptop, and it worked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for confirming. Can you please update the PR so I can approve and merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the changes, thanks again
Please click on Details for "DCO" and follow instructions to resolve it |
Closing for lack of activity. Replacing with #1928 |
the current yaml files use some beta version API, which are not supported any more by K8S, in turn, this causes failures when we run Kustomize to install flyte on customized server.
To fix the above issue, we update the apiVersion in the following three yaml files according to https://kubernetes.io/docs/reference/using-api/deprecation-guide/, and successfully deployed to our server.