Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tensorflow plugin docs #1784

Merged
merged 4 commits into from
Nov 8, 2021
Merged

Added tensorflow plugin docs #1784

merged 4 commits into from
Nov 8, 2021

Conversation

yindia
Copy link
Contributor

@yindia yindia commented Nov 2, 2021 •
edited
Loading

  • Added tensorflow plugin docs

fix: #1785

yindia added 2 commits November 2, 2021 20:30
@yindia
bump version
9f2d331 
Signed-off-by: Yuvraj <[email protected]>
@yindia
Added tensorflow docs
c60ad6c 
Signed-off-by: Yuvraj <[email protected]>
@yindia yindia requested a review from samhita-alla November 2, 2021 15:15
samhita-alla
samhita-alla reviewed Nov 3, 2021
View reviewed changes
rsts/deployment/plugin_setup/k8s/tensorflow_operator.rst

flytectl register files https://github.com/flyteorg/flytesnacks/releases/download/v0.2.225/snacks-cookbook-integrations-kubernetes-kftensorflow.tar.gz --archive -p flytesnacks -d development

8. Lastly, fetch the launch plan, create and monitor the execution.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we merge this, I think we need to have a TensorFlow example. I can try working on it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@yindia
More changes
523a20d 
Signed-off-by: Yuvraj <[email protected]>
@yindia yindia mentioned this pull request Nov 3, 2021
Closed
@yindia
Added TODO
7c9a602 
Signed-off-by: Yuvraj <[email protected]>
@yindia
Copy link
Contributor Author

yindia commented Nov 5, 2021

@kumare3 is it ok to merge it without an example. We have 2 pr(Tensorflow & Bigquery) in a similar state

@kumare3
Copy link
Contributor

kumare3 commented Nov 5, 2021

I think this is fine, but we should have an issue to write the docs for this

@yindia yindia merged commit 50794c5 into master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samhita-alla samhita-alla samhita-alla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation for tensorflow plugins and how to use/configure them
3 participants
@yindia @kumare3 @samhita-alla