Adds help command #1622
Adds help command #1622
Conversation
|
Thank you for creating this PR! @kumare3 / @EngHabu / @evalsocket, can you let me know if any other changes need to be made in the Makefiles or configuration files? If there are any, and if @hasukmistry is willing to take up those, I can approve this PR for Hacktoberfest. |
Makefile
Outdated
| .PHONY: end2end | ||
| end2end: | ||
| end2end: ## Launch dockernetes and execute tests |
There was a problem hiding this comment.
I believe this is deprecated... Can you check if it's used throughout the repo. And if not, please delete the target.
There was a problem hiding this comment.
Seems like this script end2end/launch_dockernetes.sh is still in place. I am not sure about it. I can remove target if you want me to :)
There was a problem hiding this comment.
The file exists, but I don't think end2end/launch_dockernetes.sh is being used anywhere else.
There was a problem hiding this comment.
@samhita-alla so can i remove the target?
There was a problem hiding this comment.
@evalsocket this target isn't surely required, right?
|
|
||
| .PHONY: help | ||
| help: SHELL := /bin/sh | ||
| help: ## List available commands and their usage |
There was a problem hiding this comment.
Does this work on vanilla OSX and Linux with no additional tools?
There was a problem hiding this comment.
I have tested this with Ubuntu, Mac Os without installing any additional tool.
Introduces help command in makefile. Adds comments along with make targets to display in make help section. Signed-off-by: Hasmukh K Mistry <[email protected]>
Makes changes based on suggestions Signed-off-by: Hasmukh K Mistry <[email protected]>
hasukmistry
force-pushed
the
feature/make-help-command
branch
from
91626e1 to
533cc08
Compare
Removes unused target from makefile Signed-off-by: Hasmukh K Mistry <[email protected]>
hasukmistry
force-pushed
the
feature/make-help-command
branch
from
8d82ce0 to
f16b43e
Compare
|
can we merge this PR? |
|
Congrats on merging your first pull request! 🎉 |
Introduces help command in makefile. Adds comments along with make targets to display in make help section.