Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Admin volumes to helm deployment #1470

Merged
merged 3 commits into from
Sep 16, 2021
Merged

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Sep 13, 2021

Signed-off-by: Yee Hing Tong [email protected]

This is useful to inject additional secrets which may already exist on the cluster, but for which we don't have the plaintext at helm installation time so we can't use #1087

Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor changed the title admin volumes Add Admin volumes to helm deployment Sep 13, 2021
yindia
yindia previously approved these changes Sep 14, 2021
Copy link
Contributor

@yindia yindia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also replicate these changes for flyte-core ?

Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor merged commit f33945f into master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants