Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin secrets #1087

Merged
merged 7 commits into from
Jun 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions deployment/eks/flyte_helm_generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,10 @@ metadata:
apiVersion: v1
kind: Secret
metadata:
name: flyte-admin-auth
name: flyte-admin-secrets
namespace: flyte
type: Opaque
stringData:
---
# Source: flyte/templates/common/secret.yaml
apiVersion: v1
Expand Down Expand Up @@ -1421,7 +1422,7 @@ spec:
name: resource-templates
- name: auth
secret:
secretName: flyte-admin-auth
secretName: flyte-admin-secrets
affinity:
podAntiAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
Expand Down
5 changes: 3 additions & 2 deletions deployment/gcp/flyte_helm_generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,10 @@ metadata:
apiVersion: v1
kind: Secret
metadata:
name: flyte-admin-auth
name: flyte-admin-secrets
namespace: flyte
type: Opaque
stringData:
---
# Source: flyte/templates/propeller/secret-auth.yaml
apiVersion: v1
Expand Down Expand Up @@ -3259,7 +3260,7 @@ spec:
name: resource-templates
- name: auth
secret:
secretName: flyte-admin-auth
secretName: flyte-admin-secrets
---
# Source: flyte/templates/console/deployment.yaml
apiVersion: apps/v1
Expand Down
5 changes: 3 additions & 2 deletions deployment/sandbox/flyte_helm_generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,10 @@ type: Opaque
apiVersion: v1
kind: Secret
metadata:
name: flyte-admin-auth
name: flyte-admin-secrets
namespace: flyte
type: Opaque
stringData:
---
# Source: flyte/templates/propeller/secret-auth.yaml
apiVersion: v1
Expand Down Expand Up @@ -3424,7 +3425,7 @@ spec:
name: resource-templates
- name: auth
secret:
secretName: flyte-admin-auth
secretName: flyte-admin-secrets
---
# Source: flyte/templates/console/deployment.yaml
apiVersion: apps/v1
Expand Down
1 change: 1 addition & 0 deletions helm/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ helm upgrade -f values-sandbox.yaml flyte .
| flyteadmin.podAnnotations | object | `{}` | Annotations for Flyteadmin pods |
| flyteadmin.replicaCount | int | `1` | Replicas count for Flyteadmin deployment |
| flyteadmin.resources | object | `{"limits":{"cpu":"250m","ephemeral-storage":"100Mi","memory":"500Mi"},"requests":{"cpu":"10m","ephemeral-storage":"50Mi","memory":"50Mi"}}` | Default resources requests and limits for Flyteadmin deployment |
| flyteadmin.secrets | object | `{}` | |
| flyteadmin.service | object | `{"annotations":{"projectcontour.io/upstream-protocol.h2c":"grpc"},"loadBalancerSourceRanges":[],"type":"ClusterIP"}` | Service settings for Flyteadmin |
| flyteadmin.serviceAccount | object | `{"annotations":{},"create":true,"imagePullSecrets":{}}` | Configuration for service accounts for FlyteAdmin |
| flyteadmin.serviceAccount.annotations | object | `{}` | Annotations for ServiceAccount attached to Flyteadmin pods |
Expand Down
2 changes: 1 addition & 1 deletion helm/templates/admin/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ spec:
{{- end }}
- name: auth
secret:
secretName: flyte-admin-auth
secretName: flyte-admin-secrets
{{- with .Values.flyteadmin.nodeSelector }}
nodeSelector: {{ toYaml . | nindent 8 }}
{{- end }}
Expand Down
6 changes: 5 additions & 1 deletion helm/templates/admin/secret-auth.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
apiVersion: v1
kind: Secret
metadata:
name: flyte-admin-auth
name: flyte-admin-secrets
namespace: {{ template "flyte.namespace" . }}
type: Opaque
stringData:
{{- with .Values.flyteadmin.secrets -}}
{{ toYaml . | nindent 2 }}
{{- end }}
1 change: 1 addition & 0 deletions helm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ flyteadmin:
tolerations: []
# -- affinity for Flyteadmin deployment
affinity: {}
secrets: {}

#
# DATACATALOG SETTINGS
Expand Down