Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Housekeeping] Explore using gorm validations in flyteadmin #896

Closed
katrogan opened this issue Apr 5, 2021 · 2 comments
Closed

[Housekeeping] Explore using gorm validations in flyteadmin #896

katrogan opened this issue Apr 5, 2021 · 2 comments
Assignees
@yindia
Labels
flyteadmin Issue for FlyteAdmin Service housekeeping Issues that help maintain flyte and keep it tech-debt free

Comments

@katrogan
Copy link
Contributor

katrogan commented Apr 5, 2021

Describe the Issue
Explore https://github.com/qor/validations and see if it's a viable option for replacing some hand-crafted model validation in flyteadmin.

What if we do not do this?
Potentially messier code

Related component
Flyteadmin > repositories
@katrogan katrogan added flyteadmin Issue for FlyteAdmin Service housekeeping Issues that help maintain flyte and keep it tech-debt free labels Apr 5, 2021
@katrogan katrogan assigned katrogan and unassigned katrogan Apr 5, 2021
@yindia yindia self-assigned this Apr 13, 2021
@yindia
Copy link
Contributor

yindia commented Apr 13, 2021

Related #336

@yindia yindia mentioned this issue Apr 13, 2021
Merged
8 tasks
@yindia
Copy link
Contributor

yindia commented Jun 3, 2021

@katrogan we can close this issue. we can continue our discussion on issue #336

@yindia yindia closed this as completed Jun 3, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@samhita-alla
Updates intersphinx (flyteorg#896)
1d08b9f 
update intersphinx

Signed-off-by: Samhita Alla <[email protected]>

Signed-off-by: Samhita Alla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yindia yindia

Labels
flyteadmin Issue for FlyteAdmin Service housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@katrogan @yindia