Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core Feature] A blob store reference to TaskTemplate should be an available option to commandline #850

Closed
kumare3 opened this issue Mar 19, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kumare3
Copy link
Contributor

kumare3 commented Mar 19, 2021

Motivation: Why do you think this is important?
It is possible to completely encapsulate all logic of a task into a task template and it is possible to execute such a task, without needing to build a container. But, for this it should be possible to retrieve the task template without re-hydrating the code.
This is especially important for self-contained tasks like SQL queries, or ML scripts

Goal: What should the final outcome look like, ideally?
Flytekit or other SDK's could request for tasktemplate to be a command line parameter and FlytePropeller should fill this in with a blob store reference

Describe alternatives you've considered
This is currently only possible if you build the task into the container.

[Optional] Propose: Link/Inline OR Additional context
flytekit could create a modified command line that can accept a new parameter like --task-template {{ .tasktemplate.path }}
Flytepropeller's template resolution engine, can then substitute this with a reference to a blobstore.

@kumare3 kumare3 added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers and removed untriaged This issues has not yet been looked at by the Maintainers labels Mar 19, 2021
@kumare3 kumare3 self-assigned this Mar 19, 2021
@kumare3 kumare3 added this to the 0.12.0 milestone Mar 19, 2021
@kumare3
Copy link
Contributor Author

kumare3 commented Mar 27, 2021

This is now merged and will be part of the platform release v0.12.0

@kumare3 kumare3 closed this as completed Mar 27, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
* Changed 'packages' to 'dependencies'

Signed-off-by: SmritiSatyanV <[email protected]>

* update dynamics.py

Remove the second TOC that is rendered
Change the heading level
Signed-off-by: SmritiSatyanV [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant