Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flytekit] Move translator off of old Sdk classes #822

Closed
wild-endeavor opened this issue Mar 11, 2021 · 0 comments
Closed

[Flytekit] Move translator off of old Sdk classes #822

wild-endeavor opened this issue Mar 11, 2021 · 0 comments
Assignees
@wild-endeavor
Labels
flytekit FlyteKit Python related issue
Milestone
0.14.0

Comments

@wild-endeavor
Copy link
Contributor

TL;DR

Serialize translation should not use Sdk classes. Currently when serializing objects from the new API, the translator.py script converts things to SdkTask, SdkWorkflow, SdkLaunchPlan, etc. This is not necessary, adds complexity, and fragility to the whole process. We should be going directly to the model classes.
@wild-endeavor wild-endeavor added good first issue Good for newcomers flytekit FlyteKit Python related issue labels Mar 11, 2021
@wild-endeavor wild-endeavor removed the good first issue Good for newcomers label May 18, 2021
@wild-endeavor wild-endeavor self-assigned this May 18, 2021
@wild-endeavor wild-endeavor added this to the 0.14.0 milestone May 18, 2021
@wild-endeavor wild-endeavor mentioned this issue May 19, 2021
Merged
8 tasks
@wild-endeavor wild-endeavor mentioned this issue Jan 25, 2022
Closed
2 tasks
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@marc-union
New content for map task with multiple inputs (flyteorg#822)
475af3e 
* New content for map task with multiple inputs

Signed-off-by: Marc Paquette <[email protected]>

* Typo

Co-authored-by: Samhita Alla <[email protected]>

Signed-off-by: Marc Paquette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wild-endeavor wild-endeavor

Labels
flytekit FlyteKit Python related issue
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
1 participant
@wild-endeavor