Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fast register broken for spark #653

Closed
1 of 20 tasks
katrogan opened this issue Dec 22, 2020 · 6 comments
Closed
1 of 20 tasks

[BUG] Fast register broken for spark #653

katrogan opened this issue Dec 22, 2020 · 6 comments
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers
Milestone
0.11.0

Comments

@katrogan
Copy link
Contributor

Describe the bug
For spark tasks using containers with custom entrypoints (e.g. at Lyft) fast-register is broken. This is due to how fast-register sets up the task container args to feed in the execute command into fast-execute. The container image entrypoint attempts to run spark submit with pyflyte execute (which predictably fails)

Expected behavior
Fast-register should work for spark tasks.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce

  1. Fast-register a workflow with a spark task
  2. Execute the fast registered workflow

Screenshots
If applicable, add screenshots to help explain your problem.

Environment
Flyte component

  • Sandbox (local or on one machine)
  • Cloud hosted
    • AWS
    • GCP
    • Azure
  • Baremetal
  • Other

Additional context
@katrogan katrogan added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Dec 22, 2020
@katrogan
Copy link
Contributor Author

cc @akhurana001

@kumare3
Copy link
Contributor

kumare3 commented Jan 29, 2021

@katrogan I think this is fixed with the new flytekit==0.16.0b1 right?

@kumare3
Copy link
Contributor

kumare3 commented Jan 29, 2021

we could use the same serialization settings and backport it if we want it to work for v0.15.x

@kumare3 kumare3 added this to the 0.11.0 milestone Jan 29, 2021
@katrogan
Copy link
Contributor Author

@kumare3 let me test this to confirm before closing out

@kumare3
Copy link
Contributor

kumare3 commented Feb 28, 2021

@katrogan I think we can close this one out, it works with the new versions of flytekit==0.16.0b* right

@katrogan
Copy link
Contributor Author

katrogan commented Mar 1, 2021

yes the customizable entrypoint should address this

@katrogan katrogan closed this as completed Mar 1, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@cosmicBboy
Update backend_plugins.py (flyteorg#653)
e7cae55
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@AlekhyaSasi @yindia
@SmritiSatyanV @pingsutw @samhita-alla @cosmicBboy
Remove flyte-cli references in the documentation (flyteorg#672)
ac979a7 
* Added reuse able workflow (flyteorg#660)

Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Add directive (flyteorg#663)

Signed-off-by: SmritiSatyanV <[email protected]>
Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Added links from Flytelab (flyteorg#652)

* Added link from Flytelab

Added weather forecasting application link
Minor grammar fixes
Signed-off-by: SmritiSatyanV <[email protected]>

* Created weather_forecast.rst

Created rst file to add github repo to weather-forecasting, and blog
Signed-off-by: SmritiSatyanV <[email protected]>

* Fixed errors-1

Signed-off-by: SmritiSatyanV <[email protected]>

* Updated weather_forecasting.rst

Signed-off-by: SmritiSatyanV <[email protected]>

* Added flytelab and blog link

Added description, and right links.
Signed-off-by: SmritiSatyanV <[email protected]>

* Changes to tutorials.rst

Placed the weather forecasting tab in a different position
Signed-off-by: SmritiSatyanV <[email protected]>

* updated ml_training.rst

Added description for ml_training file
Signed-off-by: SmritiSatyanV <[email protected]>

* Changes based on review

Signed-off-by: SmritiSatyanV <[email protected]>

* Changed weather forecasting drop down to flytelab

Signed-off-by: SmritiSatyanV <[email protected]>

* Changes based on comments

Signed-off-by: SmritiSatyanV <[email protected]>
Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Add AWS Batch example (flyteorg#636)

* Added aws batch example

Signed-off-by: Kevin Su <[email protected]>

* Updated dependency

Signed-off-by: Kevin Su <[email protected]>

* Update dockerfile

Signed-off-by: Kevin Su <[email protected]>

* Fixed tests

Signed-off-by: Kevin Su <[email protected]>

* rerun tests

Signed-off-by: Kevin Su <[email protected]>

* Fixed tests

Signed-off-by: Kevin Su <[email protected]>

* rerun tests

Signed-off-by: Kevin Su <[email protected]>

* Fixed tests

Signed-off-by: Kevin Su <[email protected]>

* Fixed tests

Signed-off-by: Kevin Su <[email protected]>

* Fixed tests

Signed-off-by: Kevin Su <[email protected]>

* address comment

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Moving register files example to use flytectl

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Update fast serialization

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Apply suggestions from code review

Co-authored-by: Samhita Alla <[email protected]>
Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Apply suggestions from code review

Co-authored-by: Samhita Alla <[email protected]>
Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Updated index.rst (flyteorg#670)

rephrased a sentence
Signed-off-by: SmritiSatyanV <[email protected]>
Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Minor updates (flyteorg#669)

* Minor updates
Grammar, and rendering fix
Updates based on comments
Update contribute.rst
Signed-off-by: SmritiSatyanV <[email protected]>

* Moving panel-and-toc image to static-resources repo and updating the url (flyteorg#671)

Co-authored-by: Alekhya Sai <[email protected]>
Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Update backend_plugins.py (flyteorg#653)

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Update fast_registration.py

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Update flyte_python_types.py iteration 1

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Remove flyte-cli references

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Remove fast_registration.py in favor of deploying_workflows.py

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Rewording a few sentences

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Add new line

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Remove references from lp_schedules.py

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Update instructions

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Update settings commnent

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Worked on review suggestions

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

* Add alternative option

Signed-off-by: Alekhya Sai Punnamaraju <[email protected]>

Co-authored-by: Yuvraj <[email protected]>
Co-authored-by: SmritiSatyanV <[email protected]>
Co-authored-by: Kevin Su <[email protected]>
Co-authored-by: Samhita Alla <[email protected]>
Co-authored-by: Niels Bantilan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Milestone
0.11.0
Development

No branches or pull requests
2 participants
@katrogan @kumare3