Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Enable external contributors to run tests on PRs #579

Closed
1 of 13 tasks
EngHabu opened this issue Nov 2, 2020 · 0 comments
Closed
1 of 13 tasks

[Feature] Enable external contributors to run tests on PRs #579

EngHabu opened this issue Nov 2, 2020 · 0 comments
Assignees
@EngHabu
Labels
enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers
Milestone
0.9.0

Comments

@EngHabu
Copy link
Contributor

EngHabu commented Nov 2, 2020

Motivation: Why do you think this is important?
Due to the way existing github actions were setup, it was extremely hard for external contributors to validate their changes using the same set of integration and end to end tests internal contributors have access to. This is due to requiring image registries access, secrets and so on.

Goal: What should the final outcome look like, ideally?
An external contributor opens a PR from a Fork should be able to run all the same tests and see a green icon on their PRs by the time somebody starts reviewing them.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other
@EngHabu EngHabu added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Nov 2, 2020
This was referenced Nov 2, 2020
Merged
Merged
@EngHabu EngHabu self-assigned this Nov 2, 2020
@EngHabu EngHabu modified the milestones: 0.10.0, 0.9.0 Nov 2, 2020
@EngHabu EngHabu closed this as completed Nov 4, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@SandraGH5
Editorial Review (flyteorg#579)
52d241e 
Adding syntax edits. The content has not been changed.
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@ursucarina
#minor: inputHelpers InputProps (flyteorg#579)
f027c43 
fix: inputHelpers InputProps

Signed-off-by: Carina Ursu <[email protected]>

Signed-off-by: Carina Ursu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EngHabu EngHabu

Labels
enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
1 participant
@EngHabu