Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]Log Plugins update to allow templated strings #549

Closed
1 of 13 tasks
kumare3 opened this issue Oct 13, 2020 · 3 comments
Closed
1 of 13 tasks

[Feature]Log Plugins update to allow templated strings #549

kumare3 opened this issue Oct 13, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kumare3
Copy link
Contributor

kumare3 commented Oct 13, 2020

Motivation: Why do you think this is important?
Today the Log Plugins are very limited. They only support a hardcoded link with couple parameters in the template. This works for some cases, but for many cases this is very limiting. The proposal is to overhaul the logging system to instead take a template URL and defaults in the configuration. A Clear documentation of available variables will help the user design the log string

Goal: What should the final outcome look like, ideally?
Admins should be able to update the log plugins so that the Query string is a config value,
e.g.
The API can remain constant or get updated here
but the user can specify log plugins like

logs:
    name: CloudWatch
    constants:
            - region: us-east
            - logStream: my-stream
    template_url:  "https://console.aws.amazon.com/cloudwatch/home?region={{ .constants.region }}#logEventViewer:group={{.constants.logStream}};stream=var.log.containers.{{.vars.podName}}_{{.vars.namespace}}_{{.vars.containerName}}-{{.vars.containerID}}.log"

Constants are user specified
and Vars are the default variables available in the function.

Describe alternatives you've considered
NA

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

[Optional] Propose: Link/Inline
NA

Additional context
Add any other context or screenshots about the feature request here.

Is this a blocker for you to adopt Flyte
Maybe

@kumare3 kumare3 added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Oct 13, 2020
@kumare3
Copy link
Contributor Author

kumare3 commented Oct 13, 2020

cc @varshaparthay @Vrinda (freenome)

@kumare3
Copy link
Contributor Author

kumare3 commented Jan 29, 2021

This has been merged and available

@kumare3
Copy link
Contributor Author

kumare3 commented Jan 29, 2021

We should open a docs story as a follow up

@kumare3 kumare3 closed this as completed Jan 29, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
Bumps [moment](https://github.com/moment/moment) from 2.29.3 to 2.29.4.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](moment/moment@2.29.3...2.29.4)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
Signed-off-by: byhsu <[email protected]>
This pr provides a middleware to inject user identifier to ExecutionSpec.
By default, the value of the user identifier is userid from access/id token.
Users can customize their own middleware and inject different values.
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
Signed-off-by: byhsu <[email protected]>
This pr provides a middleware to inject user identifier to ExecutionSpec.
By default, the value of the user identifier is userid from access/id token.
Users can customize their own middleware and inject different values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants