Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Have cluster resource controller leverage k8s secrets #541

Closed
1 of 13 tasks
katrogan opened this issue Oct 7, 2020 · 9 comments
Closed
1 of 13 tasks

[Feature] Have cluster resource controller leverage k8s secrets #541

katrogan opened this issue Oct 7, 2020 · 9 comments
Labels
enhancement New feature or request stale untriaged This issues has not yet been looked at by the Maintainers

Comments

@katrogan
Copy link
Contributor

katrogan commented Oct 7, 2020

Motivation: Why do you think this is important?
In addition to reading substitutable secret values from mounted file paths or injected environment variables, it would be useful to access kubernetes secrets when running the cluster resource controller.

Goal: What should the final outcome look like, ideally?
It should be possible to inject kubernetes secrets as substitutable template values in the cluster resource controller.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

[Optional] Propose: Link/Inline
If you have ideas about the implementation please propose the change. If inline keep it short, if larger then you link to an external document.

Additional context
Add any other context or screenshots about the feature request here.

Is this a blocker for you to adopt Flyte
Please let us know if this makes it impossible to adopt Flyte
@katrogan katrogan added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Oct 7, 2020
@katrogan
Copy link
Contributor Author

katrogan commented Oct 7, 2020

cc @jeevb

@jeevb
Copy link
Contributor

jeevb commented Oct 8, 2020

Thank you @katrogan. Would it be reasonable to also leverage config maps in the same way?

@kumare3
Copy link
Contributor

kumare3 commented Mar 15, 2021

this is an awesome task I think - @katrogan / @EngHabu - this ties in well with our secrets work?

@kumare3
Copy link
Contributor

kumare3 commented Mar 24, 2021

@jeevb Secrets has been merged - https://github.com/flyteorg/flytesnacks/blob/master/cookbook/core/intermediate/use_secrets.py and I think we can take this up in the next month

@EngHabu
Copy link
Contributor

EngHabu commented Nov 9, 2021

Can somebody elaborate on a concrete use-case for this?
@jeevb @katrogan

@jeevb
Copy link
Contributor

jeevb commented Nov 9, 2021

This was a nice to have at one point for injecting secrets and config maps into dynamically created flyte task namespaces. The current way to do this was rather involved using double base64-encoded secrets, mounting them as a volume and using the mounted file as a value in a cluster resource template.

That being said, we’ve since moved to pre-creating these namespaces, and don’t use cluster resource templates.

eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@james-union
fix: Graph Center on initial render (flyteorg#541)
e62b43b 
* fix: upgrade react-flow-renderer version

Signed-off-by: James <[email protected]>

* fix: use setTimeout for queue on the next render

Signed-off-by: James <[email protected]>

* fix: use one state variable and fitView after nodesChange

Signed-off-by: James <[email protected]>

* introduce needFitView
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
@katrogan
Upgrade flytepropeller (flyteorg#541)
8cf8b4a 
Signed-off-by: Katrina Rogan <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
@hamersaw
Added support for aborting task nodes reported as failures (flyteorg#541
0025cbe 
)

* added CleanupOnFailure support for TaskNodeStatus to support aborting failed task nodes

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteplugins and generated

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteplugins

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@hamersaw
Added support for aborting task nodes reported as failures (flyteorg#541
d84d9df 
)

* added CleanupOnFailure support for TaskNodeStatus to support aborting failed task nodes

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteplugins and generated

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteplugins

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@katrogan
Upgrade flytepropeller (flyteorg#541)
1fb1ed7 
Signed-off-by: Katrina Rogan <[email protected]>
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Aug 26, 2023
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@kumare3
Copy link
Contributor

kumare3 commented Dec 22, 2023

Most folks use secret manager the recommended path for this. Please refer to https://docs.flyte.org/projects/cookbook/en/latest/auto_examples/productionizing/use_secrets.html#using-secrets-in-a-task

@kumare3 kumare3 closed this as completed Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request stale untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@EngHabu @eapolinario @katrogan @jeevb @kumare3