Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Filtering executions by status in the UI doesn't always work #539

Closed
2 of 20 tasks
katrogan opened this issue Oct 7, 2020 · 2 comments · Fixed by flyteorg/flyteconsole#224
Closed
2 of 20 tasks
Assignees
Labels
bug Something isn't working ui Admin console user interface untriaged This issues has not yet been looked at by the Maintainers
Milestone

Comments

@katrogan
Copy link
Contributor

katrogan commented Oct 7, 2020

Describe the bug
Filtering workflow executions by status sometimes works. An unfiltered view might show a mix of failed and successful executions and filtering by success does indeed show the successful executions but filtering by failed shows nothing.

Expected behavior
Filters should filter specific executions by phase

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
Steps to reproduce the behavior:

  1. ...
  2. ...

Screenshots
If applicable, add screenshots to help explain your problem.

Environment
Flyte component

  • Sandbox (local or on one machine)
  • Cloud hosted
    • AWS
    • GCP
    • Azure
  • Baremetal
  • Other

Additional context
Add any other context about the problem here.

@katrogan katrogan added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Oct 7, 2020
@katrogan
Copy link
Contributor Author

katrogan commented Oct 7, 2020

cc @schottra

@schottra
Copy link
Contributor

schottra commented Oct 7, 2020

This seems to be a confusing UX pattern. The "today" and "yesterday" filters are ambiguous about what time range is being used. All times in the UI are based on UTC and the logic of the "today" filter is to take the current UTC time, round down to midnight, and search for any executions that start after that time. For users in PST/PDT, this would have the effect of searching for executions in the future if used after 4 or 5pm.
Some options:

  • Update the today/yesterday filters to be based on local time
  • Update the UI to display the actual value being filtered on, and notify the user that filters are UTC-based.
  • Update the "today" filter to be "last 24 hours", and do a similar thing with the "yesterday" filter (last 48 hours or 24-48 hours ago).

@EngHabu EngHabu added the ui Admin console user interface label Aug 30, 2021
@jsonporter jsonporter added this to the 0.18.1 milestone Oct 6, 2021
eapolinario added a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
Signed-off-by: eduardo apolinario <[email protected]>
Co-authored-by: eduardo apolinario <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
…g#539)

* Continue supporting config kvversion as default arg

Signed-off-by: Tim Bauer <[email protected]>

* Remove obsolete test

Signed-off-by: Tim Bauer <[email protected]>

* Add deprecation information

Signed-off-by: Tim Bauer <[email protected]>

* Remove comment

Signed-off-by: Tim Bauer <[email protected]>

* Remove comments

Signed-off-by: Tim Bauer <[email protected]>

---------

Signed-off-by: Tim Bauer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
…g#539)

* Continue supporting config kvversion as default arg

Signed-off-by: Tim Bauer <[email protected]>

* Remove obsolete test

Signed-off-by: Tim Bauer <[email protected]>

* Add deprecation information

Signed-off-by: Tim Bauer <[email protected]>

* Remove comment

Signed-off-by: Tim Bauer <[email protected]>

* Remove comments

Signed-off-by: Tim Bauer <[email protected]>

---------

Signed-off-by: Tim Bauer <[email protected]>
eapolinario added a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
Signed-off-by: eduardo apolinario <[email protected]>
Co-authored-by: eduardo apolinario <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui Admin console user interface untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants