Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Make ProjectLabels available to plugins #521

Closed
3 of 13 tasks
EngHabu opened this issue Sep 23, 2020 · 3 comments
Closed
3 of 13 tasks

[Feature] Make ProjectLabels available to plugins #521

EngHabu opened this issue Sep 23, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@EngHabu
Copy link
Contributor

EngHabu commented Sep 23, 2020

Motivation: Why do you think this is important?
FlyteAdmin offers a way to associate free-form metadata with each project. They are meant to be agnostic to Flyte system but available for querying at various stages. This feature request is to make them available to plugins to be used for tagging some external system that are aware of the keys in these dictionaries.

Goal: What should the final outcome look like, ideally?
A GetProjectLabels() map[string]string method defined here that gets filled in from FlyteAdmin all the way to plugins.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

[Optional] Propose: Link/Inline
In order to achieve that, a few changes will need to happen:

  • FlyteWorkflow WorkflowMeta (defined in FlytePropeller repo here) an additional ProjectLabels map[string]string added.
  • FlyteAdmin, when it creates a FlyteWorkflow here, needs to set that new field.
  • Add a GetProjectLabels() map[string]string method defined here
  • FlytePropeller TaskExecutionContext (the implementation of the above interface) should then implement this new function.
@kumare3
Copy link
Contributor

kumare3 commented Oct 5, 2020

@EngHabu my preference is to use the K8s labels for the CRD as a way to pass along the project labels too. Thus project labels become the base set of labels applied to every workflow execution and can be overriden per execution etc.
This also requires no changes to propeller or any of the plugins. and the behavior is easy to understand. Otherwsie its not clear what project labels and workflow labels are and how they differ

@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Jan 29, 2021
@kumare3 kumare3 added this to the 0.11.0 milestone Jan 29, 2021
@kumare3
Copy link
Contributor

kumare3 commented Jan 29, 2021

This is merged and available

@EngHabu
Copy link
Contributor Author

EngHabu commented Mar 3, 2021

Triage: WorkflowId and WorkflowExecutionId have been made available to plugins' consumption but not Project labels. It satisfied the request at the moment. Closing

@EngHabu EngHabu closed this as completed Mar 3, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
* Add bigquery example

Signed-off-by: Kevin Su <[email protected]>

* Add makefile

Signed-off-by: Kevin Su <[email protected]>

* Updated example

Signed-off-by: Kevin Su <[email protected]>

* Updated comment

Signed-off-by: Kevin Su <[email protected]>

* Updated requirement

Signed-off-by: Kevin Su <[email protected]>

* Updated dependency

Signed-off-by: Kevin Su <[email protected]>

* use annotated

Signed-off-by: Kevin Su <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
* wip

Signed-off-by: Katrina Rogan <[email protected]>

* recovery

Signed-off-by: Katrina Rogan <[email protected]>

* test compile

Signed-off-by: Katrina Rogan <[email protected]>

* GH ur my fave diff tool

Signed-off-by: Katrina Rogan <[email protected]>

* revert styling changes

Signed-off-by: Katrina Rogan <[email protected]>

* more test

Signed-off-by: Katrina Rogan <[email protected]>

* goimports

Signed-off-by: Katrina Rogan <[email protected]>

* rm log line

Signed-off-by: Katrina Rogan <[email protected]>

* changes

Signed-off-by: Katrina Rogan <[email protected]>

* lint

Signed-off-by: Katrina Rogan <[email protected]>

* review comment

Signed-off-by: Katrina Rogan <[email protected]>

* go.mod

Signed-off-by: Katrina Rogan <[email protected]>

* review comment

Signed-off-by: Katrina Rogan <[email protected]>

---------

Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Co-authored-by: Katrina Rogan <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
* wip

Signed-off-by: Katrina Rogan <[email protected]>

* recovery

Signed-off-by: Katrina Rogan <[email protected]>

* test compile

Signed-off-by: Katrina Rogan <[email protected]>

* GH ur my fave diff tool

Signed-off-by: Katrina Rogan <[email protected]>

* revert styling changes

Signed-off-by: Katrina Rogan <[email protected]>

* more test

Signed-off-by: Katrina Rogan <[email protected]>

* goimports

Signed-off-by: Katrina Rogan <[email protected]>

* rm log line

Signed-off-by: Katrina Rogan <[email protected]>

* changes

Signed-off-by: Katrina Rogan <[email protected]>

* lint

Signed-off-by: Katrina Rogan <[email protected]>

* review comment

Signed-off-by: Katrina Rogan <[email protected]>

* go.mod

Signed-off-by: Katrina Rogan <[email protected]>

* review comment

Signed-off-by: Katrina Rogan <[email protected]>

---------

Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Co-authored-by: Katrina Rogan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants