-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Make ProjectLabels available to plugins #521
Comments
@EngHabu my preference is to use the K8s labels for the CRD as a way to pass along the project labels too. Thus project labels become the base set of labels applied to every workflow execution and can be overriden per execution etc. |
This is merged and available |
Triage: WorkflowId and WorkflowExecutionId have been made available to plugins' consumption but not Project labels. It satisfied the request at the moment. Closing |
* Add bigquery example Signed-off-by: Kevin Su <[email protected]> * Add makefile Signed-off-by: Kevin Su <[email protected]> * Updated example Signed-off-by: Kevin Su <[email protected]> * Updated comment Signed-off-by: Kevin Su <[email protected]> * Updated requirement Signed-off-by: Kevin Su <[email protected]> * Updated dependency Signed-off-by: Kevin Su <[email protected]> * use annotated Signed-off-by: Kevin Su <[email protected]>
* wip Signed-off-by: Katrina Rogan <[email protected]> * recovery Signed-off-by: Katrina Rogan <[email protected]> * test compile Signed-off-by: Katrina Rogan <[email protected]> * GH ur my fave diff tool Signed-off-by: Katrina Rogan <[email protected]> * revert styling changes Signed-off-by: Katrina Rogan <[email protected]> * more test Signed-off-by: Katrina Rogan <[email protected]> * goimports Signed-off-by: Katrina Rogan <[email protected]> * rm log line Signed-off-by: Katrina Rogan <[email protected]> * changes Signed-off-by: Katrina Rogan <[email protected]> * lint Signed-off-by: Katrina Rogan <[email protected]> * review comment Signed-off-by: Katrina Rogan <[email protected]> * go.mod Signed-off-by: Katrina Rogan <[email protected]> * review comment Signed-off-by: Katrina Rogan <[email protected]> --------- Signed-off-by: Katrina Rogan <[email protected]> Signed-off-by: Katrina Rogan <[email protected]> Co-authored-by: Katrina Rogan <[email protected]>
* wip Signed-off-by: Katrina Rogan <[email protected]> * recovery Signed-off-by: Katrina Rogan <[email protected]> * test compile Signed-off-by: Katrina Rogan <[email protected]> * GH ur my fave diff tool Signed-off-by: Katrina Rogan <[email protected]> * revert styling changes Signed-off-by: Katrina Rogan <[email protected]> * more test Signed-off-by: Katrina Rogan <[email protected]> * goimports Signed-off-by: Katrina Rogan <[email protected]> * rm log line Signed-off-by: Katrina Rogan <[email protected]> * changes Signed-off-by: Katrina Rogan <[email protected]> * lint Signed-off-by: Katrina Rogan <[email protected]> * review comment Signed-off-by: Katrina Rogan <[email protected]> * go.mod Signed-off-by: Katrina Rogan <[email protected]> * review comment Signed-off-by: Katrina Rogan <[email protected]> --------- Signed-off-by: Katrina Rogan <[email protected]> Signed-off-by: Katrina Rogan <[email protected]> Co-authored-by: Katrina Rogan <[email protected]>
Motivation: Why do you think this is important?
FlyteAdmin offers a way to associate free-form metadata with each project. They are meant to be agnostic to Flyte system but available for querying at various stages. This feature request is to make them available to plugins to be used for tagging some external system that are aware of the keys in these dictionaries.
Goal: What should the final outcome look like, ideally?
A
GetProjectLabels() map[string]string
method defined here that gets filled in from FlyteAdmin all the way to plugins.Flyte component
[Optional] Propose: Link/Inline
In order to achieve that, a few changes will need to happen:
ProjectLabels map[string]string
added.GetProjectLabels() map[string]string
method defined hereThe text was updated successfully, but these errors were encountered: