Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Propeller should fail the workflow when it can't write to etcd #511

Closed
1 of 20 tasks
wild-endeavor opened this issue Sep 15, 2020 · 1 comment
Closed
1 of 20 tasks
Assignees
Labels
bug Something isn't working
Milestone

Comments

@wild-endeavor
Copy link
Contributor

Describe the bug
Propeller doesn't error on

msg:Failed to update workflow. Error [Request entity too large: limit is 3145728]

Expected behavior
It should be recorded as an internal error. After system retries, the workflow should fail with that message.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
Steps to reproduce the behavior:

  1. Run a dynamic task with thousands and thousands of subtasks.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment
Flyte component

  • Sandbox (local or on one machine)
  • Cloud hosted
    • AWS
    • GCP
    • Azure
  • Baremetal
  • Other

Additional context
Add any other context about the problem here.

@wild-endeavor wild-endeavor added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Sep 15, 2020
@wild-endeavor wild-endeavor changed the title [BUG] [BUG] Propeller should fail the workflow when it can't write to etcd Sep 15, 2020
@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Mar 18, 2021
@kumare3 kumare3 self-assigned this Mar 18, 2021
@kumare3 kumare3 added this to the 0.12.0 milestone Mar 18, 2021
@kumare3
Copy link
Contributor

kumare3 commented Mar 24, 2021

related to #363. currently in PR

@kumare3 kumare3 closed this as completed Mar 27, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
* feat: navbar navigstion dropdown
* chore: storybook update
* chore: fix test + add base readme

Signed-off-by: Nastya <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
…lyteorg#511)

* fixing issue where k8s plugin default labels override those set on pod

Signed-off-by: Dan Rammer <[email protected]>

* updated flyteplugins dependency

Signed-off-by: Dan Rammer <[email protected]>

Signed-off-by: Dan Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
…lyteorg#511)

* fixing issue where k8s plugin default labels override those set on pod

Signed-off-by: Dan Rammer <[email protected]>

* updated flyteplugins dependency

Signed-off-by: Dan Rammer <[email protected]>

Signed-off-by: Dan Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants