Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Remove dependence on pyspark for non-spark notebooks #488

Closed
20 tasks
akhurana001 opened this issue Aug 27, 2020 · 0 comments
Closed
20 tasks

[BUG] Remove dependence on pyspark for non-spark notebooks #488

akhurana001 opened this issue Aug 27, 2020 · 0 comments
Assignees
@akhurana001
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers

Comments

@akhurana001
Copy link
Contributor

Describe the bug
Currently a simple python_notebook task will need pyspark installed to be successfully run. This is not ideal and can be avoided.

Expected behavior

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
Steps to reproduce the behavior:

  1. ...
  2. ...

Screenshots
If applicable, add screenshots to help explain your problem.

Environment
Flyte component

  • Sandbox (local or on one machine)
  • Cloud hosted
    • AWS
    • GCP
    • Azure
  • Baremetal
  • Other

Additional context
Add any other context about the problem here.
@akhurana001 akhurana001 added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Aug 27, 2020
@akhurana001 akhurana001 mentioned this issue Aug 27, 2020
Merged
8 tasks
@kumare3 kumare3 closed this as completed Sep 2, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@andrewwdye
Add subject to UserInfoResponse header (flyteorg#488)
32573f6 
Signed-off-by: Andrew Dye <[email protected]>

Signed-off-by: Andrew Dye <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@SandraGH5
Remove the referral to a flowchart (flyteorg#488)
4fc3229 
Remove the following statement about when to write a backend plugin: 
"To understand when you should write a backend plugin refer to - TODO: Flow chart that helps you decide when to write a backend / flytekit plugin?"
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@eugenejahn @anrusina
feat: rerun task action in execution page (flyteorg#488)
4a23f4e 
* feat: task rerun done

Signed-off-by: Eugene Jahn <[email protected]>

* feat: fix initialParameters

Signed-off-by: Eugene Jahn <[email protected]>

* fix: remove a file

Signed-off-by: Eugene Jahn <[email protected]>

* feat: rerun task done

Signed-off-by: Eugene Jahn <[email protected]>

* feat: rerun fix literal type

Signed-off-by: Eugene Jahn <[email protected]>

* feat: small typo fixed

Signed-off-by: Eugene Jahn <[email protected]>

* feat: small typo fixed

Signed-off-by: Eugene Jahn <[email protected]>

* feat: fix test coverage

Signed-off-by: Eugene Jahn <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
@hamersaw
Fast fail if task resource requests exceed k8s resource limits (flyte…
f4cadb0 
…org#488)

* checking if task resource requests exceed k8s limits

Signed-off-by: Daniel Rammer <[email protected]>

* added better message to task failure

Signed-off-by: Daniel Rammer <[email protected]>

* added request checks

Signed-off-by: Daniel Rammer <[email protected]>

* added tests for checking resource eligibility

Signed-off-by: Daniel Rammer <[email protected]>

* fixed lint issues

Signed-off-by: Daniel Rammer <[email protected]>

* updated comment

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@hamersaw
Fast fail if task resource requests exceed k8s resource limits (flyte…
ca038b5 
…org#488)

* checking if task resource requests exceed k8s limits

Signed-off-by: Daniel Rammer <[email protected]>

* added better message to task failure

Signed-off-by: Daniel Rammer <[email protected]>

* added request checks

Signed-off-by: Daniel Rammer <[email protected]>

* added tests for checking resource eligibility

Signed-off-by: Daniel Rammer <[email protected]>

* fixed lint issues

Signed-off-by: Daniel Rammer <[email protected]>

* updated comment

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@andrewwdye
Add subject to UserInfoResponse header (flyteorg#488)
751596c 
Signed-off-by: Andrew Dye <[email protected]>

Signed-off-by: Andrew Dye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akhurana001 akhurana001

Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kumare3 @akhurana001