-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Permit enabling plugins for certain projects + domains #484
Comments
@EngHabu @kumare3 mind reviewing? |
@katrogan thank you for filing this issue, this makes sense to me. The intention of |
I'm 💯 behind the proposal you outlined here instead of the approach outlined above. |
@EngHabu thanks! since the other issue encapsulates this one, I'll close this out and use the linked issue for tracking work items |
Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Daniel Rammer <[email protected]>
* Fixed PATH for gcloud Signed-off-by: Prafulla Mahindrakar <[email protected]> * Removed curl installation in mnist classifier Signed-off-by: Prafulla Mahindrakar <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Daniel Rammer <[email protected]>
Motivation: Why do you think this is important?
Currently an enabled plugin is applied for all matching task types. This poses several problems. As part of the process for deploying and testing new plugins, there is no means to gradually introduce one plugin implementation as a replacement for a given task type. Furthermore, sometimes individual users are interested in one implementation vs another (e.g. k8s array tasks vs batch for having access to credentials).
Goal: What should the final outcome look like, ideally?
Alternate plugin implementations for a task type should be configurable via a project+domain whitelist. e.g.
In this example, all projects+domains will always have the container plugin enabled. However, the
container_array
implementation will default to the aws batch plugin. In the case of executions running in the production domain formy_project
ormy_other_project
thecontainer_array
plugin used will be k8s-array since it is registered for the same task type.Describe alternatives you've considered
Another means of permitting split testing for a replacement plugin implementation could include a percentage-based traffic split. However this is non-deterministic which leads to confusing behavior for customer teams.
Flyte component
[Optional] Propose: Link/Inline
This change will require updating WranglePluginsAndGenerateFinalList and plugin selection in ResolvePlugin
Additional context
This is to facilitate testing out improvements to the k8s array plugin.
Is this a blocker for you to adopt Flyte
N/A
The text was updated successfully, but these errors were encountered: