Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] flyteconsole generates wrong link towards stackdriver logs #480

Closed
4 of 20 tasks
honnix opened this issue Aug 24, 2020 · 5 comments
Closed
4 of 20 tasks

[BUG] flyteconsole generates wrong link towards stackdriver logs #480

honnix opened this issue Aug 24, 2020 · 5 comments
Assignees
@honnix
Labels
bug Something isn't working
Milestone
0.7.0

Comments

@honnix
Copy link
Member

honnix commented Aug 24, 2020 •
edited
Loading

Describe the bug
As this line says, flyteconsole assumes logName to be the pod name, however this has not been the case since certain version (that I'm not sure of, and maybe since deprecating old Stackdriver logging/monitoring) of GKE.

logName now simply refers to projects/<gcp-project>/logs/stderr or projects/<gcp-project>/logs/stdout.

Expected behavior
flyteconsole generates the correct link towards Stackdriver logs.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
Steps to reproduce the behavior:

  1. Execute a launch plan
  2. Pick up any node
  3. Click View Logs
  4. On the sidebar, click Stackdriver Logs (User)
  5. A new tab/window is opened with no log showing up

Screenshots
Screenshot 2020-08-24 at 21 55 24

Environment
Flyte component

  • Sandbox (local or on one machine)
  • Cloud hosted
    • AWS
    • GCP
    • Azure
  • Baremetal
  • Other

Additional context
Change the advancedFilter to resource.labels.pod_name%3D<pod name> should fix it.
@honnix honnix added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Aug 24, 2020
@honnix honnix mentioned this issue Aug 24, 2020
Merged
8 tasks
@honnix honnix self-assigned this Aug 25, 2020
@honnix honnix removed the untriaged This issues has not yet been looked at by the Maintainers label Aug 25, 2020
@wild-endeavor wild-endeavor added this to the 0.7.0 milestone Aug 25, 2020
@honnix
Copy link
Member Author

honnix commented Aug 27, 2020 •
edited
Loading

Closed by #79 flyteorg/flyteidl#79

@honnix honnix closed this as completed Aug 27, 2020
@honnix
Copy link
Member Author

honnix commented Aug 27, 2020

@wild-endeavor Sorry for closing this without asking you. Are we supposed to close an issue only after making a new release?

@wild-endeavor
Copy link
Contributor

Oh no it's okay. Thanks!

@wild-endeavor
Copy link
Contributor

wild-endeavor commented Aug 27, 2020 •
edited
Loading

It's fixed? Or does issue #79 cover this? (It seems to be a pretty different issue)

@honnix
Copy link
Member Author

honnix commented Aug 27, 2020

Sorry it is a wrong repo. :(

eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@wild-endeavor
Project settings (flyteorg#480)
2f2be8a 
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: pmahindrakar-oss <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@wild-endeavor
Project settings (flyteorg#480)
b47e646 
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: pmahindrakar-oss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@honnix honnix

Labels
bug Something isn't working
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
2 participants
@honnix @wild-endeavor