Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Default CORS enabled from localhost:8080 for Admin. #447

Closed
1 of 13 tasks
kumare3 opened this issue Aug 5, 2020 · 1 comment
Closed
1 of 13 tasks

[Feature] Default CORS enabled from localhost:8080 for Admin. #447

kumare3 opened this issue Aug 5, 2020 · 1 comment
Assignees
@kumare3
Labels
enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers
Milestone
0.8.0

Comments

@kumare3
Copy link
Contributor

kumare3 commented Aug 5, 2020

Motivation: Why do you think this is important?
Many times when users start working with Flyte, they port forward FlyteAdmin and FlyteConsole. Just allowing CORS would make console work perfectly for them. Let us have this enabled as default and we can write this in docs

Goal: What should the final outcome look like, ideally?
User should be able to port-forward flyteconsole to 8080 and flyteadmin to 8081 and this should just work.

Describe alternatives you've considered
Manually adding CORS everytimg

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

Is this a blocker for you to adopt Flyte
This would make getting started with Flyte even smoother
@kumare3 kumare3 added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Aug 5, 2020
@kumare3
Copy link
Contributor Author

kumare3 commented Oct 6, 2020

FlyteAdmin after Flyte v0.8.0 in sandbox has cors disabled by default, Resolving the issue

@kumare3 kumare3 self-assigned this Oct 6, 2020
@kumare3 kumare3 added this to the 0.8.0 milestone Oct 6, 2020
@kumare3 kumare3 closed this as completed Oct 6, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@honnix
Upgrade flyteidl, preload lb policy and add default service config fo…
b9fb6e3 
…r catalog client (flyteorg#447)
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@katrogan
Pass along raw claims in identity context (flyteorg#447)
b29605d
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@anrusina
ci: allow to start jest config for all project at once (flyteorg#447)
b513280
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@honnix
Upgrade flyteidl, preload lb policy and add default service config fo…
66b0d90 
…r catalog client (flyteorg#447)
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@katrogan
Pass along raw claims in identity context (flyteorg#447)
afb3383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumare3 kumare3

Labels
enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
1 participant
@kumare3