Default timeout policy #43
Comments
|
This has been merged. There is a configurable default timeout |
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Dec 6, 2022
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Dec 6, 2022
This is the last bit of auth work on the Admin side of things. Before this PR, if you present Admin with a bad or expired token, you will get a 401. However, if you present no token whatsoever, Admin will let the request go through. This PR begins enforcement. To help with migration, we are incrementally going to require auth. We were originally going to use the gRPC endpoint name to decide whether or not to enforce things, but ultimately it made more sense to divide up by protocol - HTTP vs gRPC. Since most programmatic (more problematic) traffic goes through gRPC and only Flyte Console uses HTTP, we can start by just doing HTTP. In order to do this, the code tags incoming HTTP requests because the token validation code is further downstream. Also * Adding the bit of code to look for bearer tokens in http headers as well as cookies to support use-cases where we use the HTTP Admin API. Note however, that Admin will be deployed with a custom config so that the header you should send is `Flyte-Authorization` not the default `Authorization`, so the complete header would look something like `Flyte-Authorization: Bearer j.w.t`
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Dec 6, 2022
* Separating Workflow Metadata and Defaults * make generate Co-authored-by: Miguel Toledo <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Dec 20, 2022
* Add metrics and name for cache * Mark autorefresh cache as deprecated * Remove items from the workqueue after they're processed
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Dec 20, 2022
Before the plugin api refactor, we used to add these [tags](https://github.com/lyft/flyteplugins/blob/301315810dbc9361567645c6961b97d5c968f2a3/go/tasks/v1/qubole/hive_executor.go#L173-L176) but they were lost in translation. This adds them back.
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Dec 20, 2022
Signed-off-by: Yuvraj <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Dec 20, 2022
* WIP: add reservation apis Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add missing files Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * added create DAO Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Add get dao Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * wip Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * fix tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * wired reservation manager Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add todos Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more logging Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add logging and stats Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * fix lint Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more comments Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * First -> Take Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * WIP: add createOrupdate API Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Added boilerplate automation (flyteorg#41) Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * update boilerplate code (flyteorg#40) Signed-off-by: Samhita Alla <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Upgrade gorm to v1.21.9 (flyteorg#42) Signed-off-by: Daniel Rammer <[email protected]> * Added boilerplate automation (flyteorg#43) Signed-off-by: Yuvraj <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more instructinos Use upsert Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more comments Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * refactor a bit Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add timer Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * fix lint / tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add comments & tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * fix lint Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add docs Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Fix connection error handling (flyteorg#45) Signed-off-by: Daniel Rammer <[email protected]> * Update code of conduct (flyteorg#46) Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * separated ReservationManager CreateOrUpdate function into individual Create and Update functions Signed-off-by: Daniel Rammer <[email protected]> * fixed race condition on Reservation repository Create function Signed-off-by: Daniel Rammer <[email protected]> * changed reservation expiration to use heartbeatInterval and heartbeatGracePeriodMultiplier Signed-off-by: Daniel Rammer <[email protected]> * fixed lint and unit test errors Signed-off-by: Daniel Rammer <[email protected]> * added unit tests for extending reservation and update failure Signed-off-by: Daniel Rammer <[email protected]> * removed ExtendReservation API mocks Signed-off-by: Daniel Rammer <[email protected]> * added ExpiresAt and HeartbeatInterval fiedls to ReservationStatus return based on new API Signed-off-by: Daniel Rammer <[email protected]> * implemented ReleaseReservation Signed-off-by: Daniel Rammer <[email protected]> * added unit tests for reservation transformer Signed-off-by: Daniel Rammer <[email protected]> * fixed lint errors Signed-off-by: Daniel Rammer <[email protected]> * implemented unit tests for ReleaseReservation API call Signed-off-by: Daniel Rammer <[email protected]> * updated reservation API to only work with reservations - not actual artifacts. Signed-off-by: Daniel Rammer <[email protected]> * Fix error type check to detect uniqueConstraintViolation Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Revert "Fix error type check to detect uniqueConstraintViolation" This reverts commit 2ba0775. Signed-off-by: Daniel Rammer <[email protected]> * Fix gorm wrong error type cast (flyteorg#48) * Fix gorm wrong error type cast Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * Support unwrapping errors to detect connection problems Signed-off-by: Haytham Abuelfutuh <[email protected]> * cleanup Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * added support for heartbeat_interval definition in reservation manager Signed-off-by: Daniel Rammer <[email protected]> * updated test and fixed lint errors Signed-off-by: Daniel Rammer <[email protected]> * removed unnecessary dependencies from go.mod Signed-off-by: Daniel Rammer <[email protected]> * updated flyteidl version - change before merging Signed-off-by: Daniel Rammer <[email protected]> * adding reservation model to migration Signed-off-by: Daniel Rammer <[email protected]> * udpated dockerfile go template to reflect current master fixing rebase overwrites Signed-off-by: Daniel Rammer <[email protected]> * and again .. with a space Signed-off-by: Daniel Rammer <[email protected]> * add docs on exports Signed-off-by: Daniel Rammer <[email protected]> * changed configuration to use config.Duration from flytestdlib instead of defining on seconds Signed-off-by: Daniel Rammer <[email protected]> * added owner id to reservation gorm impl delete function Signed-off-by: Daniel Rammer <[email protected]> * if reservation is missing on release reservation (meaning another entity acquired it) then gracefully fail Signed-off-by: Daniel Rammer <[email protected]> * updated flyteidl version Signed-off-by: Daniel Rammer <[email protected]> * remove flyteidl replace in go.mod and updating to latest version Signed-off-by: Daniel Rammer <[email protected]> Co-authored-by: Chao-Han Tsai <[email protected]> Co-authored-by: Yuvraj <[email protected]> Co-authored-by: Samhita Alla <[email protected]> Co-authored-by: Haytham Abuelfutuh <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Aug 9, 2023
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Aug 21, 2023
* Add metrics and name for cache * Mark autorefresh cache as deprecated * Remove items from the workqueue after they're processed
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Aug 21, 2023
This is the last bit of auth work on the Admin side of things. Before this PR, if you present Admin with a bad or expired token, you will get a 401. However, if you present no token whatsoever, Admin will let the request go through. This PR begins enforcement. To help with migration, we are incrementally going to require auth. We were originally going to use the gRPC endpoint name to decide whether or not to enforce things, but ultimately it made more sense to divide up by protocol - HTTP vs gRPC. Since most programmatic (more problematic) traffic goes through gRPC and only Flyte Console uses HTTP, we can start by just doing HTTP. In order to do this, the code tags incoming HTTP requests because the token validation code is further downstream. Also * Adding the bit of code to look for bearer tokens in http headers as well as cookies to support use-cases where we use the HTTP Admin API. Note however, that Admin will be deployed with a custom config so that the header you should send is `Flyte-Authorization` not the default `Authorization`, so the complete header would look something like `Flyte-Authorization: Bearer j.w.t`
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Aug 21, 2023
Before the plugin api refactor, we used to add these [tags](https://github.com/lyft/flyteplugins/blob/ca70572f2eaf718be65fe92fb7887aee9a408c20/go/tasks/v1/qubole/hive_executor.go#L173-L176) but they were lost in translation. This adds them back.
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Aug 21, 2023
Signed-off-by: Yuvraj <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Aug 21, 2023
* WIP: add reservation apis Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add missing files Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * added create DAO Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Add get dao Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * wip Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * fix tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * wired reservation manager Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add todos Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more logging Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add logging and stats Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * fix lint Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more comments Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * First -> Take Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * WIP: add createOrupdate API Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Added boilerplate automation (flyteorg#41) Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * update boilerplate code (flyteorg#40) Signed-off-by: Samhita Alla <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Upgrade gorm to v1.21.9 (flyteorg#42) Signed-off-by: Daniel Rammer <[email protected]> * Added boilerplate automation (flyteorg#43) Signed-off-by: Yuvraj <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more instructinos Use upsert Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more comments Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * refactor a bit Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add timer Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * fix lint / tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add comments & tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * fix lint Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add docs Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Fix connection error handling (flyteorg#45) Signed-off-by: Daniel Rammer <[email protected]> * Update code of conduct (flyteorg#46) Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * separated ReservationManager CreateOrUpdate function into individual Create and Update functions Signed-off-by: Daniel Rammer <[email protected]> * fixed race condition on Reservation repository Create function Signed-off-by: Daniel Rammer <[email protected]> * changed reservation expiration to use heartbeatInterval and heartbeatGracePeriodMultiplier Signed-off-by: Daniel Rammer <[email protected]> * fixed lint and unit test errors Signed-off-by: Daniel Rammer <[email protected]> * added unit tests for extending reservation and update failure Signed-off-by: Daniel Rammer <[email protected]> * removed ExtendReservation API mocks Signed-off-by: Daniel Rammer <[email protected]> * added ExpiresAt and HeartbeatInterval fiedls to ReservationStatus return based on new API Signed-off-by: Daniel Rammer <[email protected]> * implemented ReleaseReservation Signed-off-by: Daniel Rammer <[email protected]> * added unit tests for reservation transformer Signed-off-by: Daniel Rammer <[email protected]> * fixed lint errors Signed-off-by: Daniel Rammer <[email protected]> * implemented unit tests for ReleaseReservation API call Signed-off-by: Daniel Rammer <[email protected]> * updated reservation API to only work with reservations - not actual artifacts. Signed-off-by: Daniel Rammer <[email protected]> * Fix error type check to detect uniqueConstraintViolation Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Revert "Fix error type check to detect uniqueConstraintViolation" This reverts commit a237bf0. Signed-off-by: Daniel Rammer <[email protected]> * Fix gorm wrong error type cast (flyteorg#48) * Fix gorm wrong error type cast Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * Support unwrapping errors to detect connection problems Signed-off-by: Haytham Abuelfutuh <[email protected]> * cleanup Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * added support for heartbeat_interval definition in reservation manager Signed-off-by: Daniel Rammer <[email protected]> * updated test and fixed lint errors Signed-off-by: Daniel Rammer <[email protected]> * removed unnecessary dependencies from go.mod Signed-off-by: Daniel Rammer <[email protected]> * updated flyteidl version - change before merging Signed-off-by: Daniel Rammer <[email protected]> * adding reservation model to migration Signed-off-by: Daniel Rammer <[email protected]> * udpated dockerfile go template to reflect current master fixing rebase overwrites Signed-off-by: Daniel Rammer <[email protected]> * and again .. with a space Signed-off-by: Daniel Rammer <[email protected]> * add docs on exports Signed-off-by: Daniel Rammer <[email protected]> * changed configuration to use config.Duration from flytestdlib instead of defining on seconds Signed-off-by: Daniel Rammer <[email protected]> * added owner id to reservation gorm impl delete function Signed-off-by: Daniel Rammer <[email protected]> * if reservation is missing on release reservation (meaning another entity acquired it) then gracefully fail Signed-off-by: Daniel Rammer <[email protected]> * updated flyteidl version Signed-off-by: Daniel Rammer <[email protected]> * remove flyteidl replace in go.mod and updating to latest version Signed-off-by: Daniel Rammer <[email protected]> Co-authored-by: Chao-Han Tsai <[email protected]> Co-authored-by: Yuvraj <[email protected]> Co-authored-by: Samhita Alla <[email protected]> Co-authored-by: Haytham Abuelfutuh <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Aug 21, 2023
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
pushed a commit
that referenced
this issue
Sep 7, 2023
Signed-off-by: Yuvraj <[email protected]>
eapolinario
pushed a commit
that referenced
this issue
Sep 7, 2023
* WIP: add reservation apis Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add missing files Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * added create DAO Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Add get dao Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * wip Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * fix tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * wired reservation manager Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add todos Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more logging Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add logging and stats Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * fix lint Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more comments Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * First -> Take Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * WIP: add createOrupdate API Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Added boilerplate automation (#41) Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * update boilerplate code (#40) Signed-off-by: Samhita Alla <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Upgrade gorm to v1.21.9 (#42) Signed-off-by: Daniel Rammer <[email protected]> * Added boilerplate automation (#43) Signed-off-by: Yuvraj <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more instructinos Use upsert Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add more comments Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * refactor a bit Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add timer Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * fix lint / tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add comments & tests Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * fix lint Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * add docs Signed-off-by: Chao-Han Tsai <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Fix connection error handling (#45) Signed-off-by: Daniel Rammer <[email protected]> * Update code of conduct (#46) Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * separated ReservationManager CreateOrUpdate function into individual Create and Update functions Signed-off-by: Daniel Rammer <[email protected]> * fixed race condition on Reservation repository Create function Signed-off-by: Daniel Rammer <[email protected]> * changed reservation expiration to use heartbeatInterval and heartbeatGracePeriodMultiplier Signed-off-by: Daniel Rammer <[email protected]> * fixed lint and unit test errors Signed-off-by: Daniel Rammer <[email protected]> * added unit tests for extending reservation and update failure Signed-off-by: Daniel Rammer <[email protected]> * removed ExtendReservation API mocks Signed-off-by: Daniel Rammer <[email protected]> * added ExpiresAt and HeartbeatInterval fiedls to ReservationStatus return based on new API Signed-off-by: Daniel Rammer <[email protected]> * implemented ReleaseReservation Signed-off-by: Daniel Rammer <[email protected]> * added unit tests for reservation transformer Signed-off-by: Daniel Rammer <[email protected]> * fixed lint errors Signed-off-by: Daniel Rammer <[email protected]> * implemented unit tests for ReleaseReservation API call Signed-off-by: Daniel Rammer <[email protected]> * updated reservation API to only work with reservations - not actual artifacts. Signed-off-by: Daniel Rammer <[email protected]> * Fix error type check to detect uniqueConstraintViolation Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * Revert "Fix error type check to detect uniqueConstraintViolation" This reverts commit 22c2d03. Signed-off-by: Daniel Rammer <[email protected]> * Fix gorm wrong error type cast (#48) * Fix gorm wrong error type cast Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * Support unwrapping errors to detect connection problems Signed-off-by: Haytham Abuelfutuh <[email protected]> * cleanup Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> * added support for heartbeat_interval definition in reservation manager Signed-off-by: Daniel Rammer <[email protected]> * updated test and fixed lint errors Signed-off-by: Daniel Rammer <[email protected]> * removed unnecessary dependencies from go.mod Signed-off-by: Daniel Rammer <[email protected]> * updated flyteidl version - change before merging Signed-off-by: Daniel Rammer <[email protected]> * adding reservation model to migration Signed-off-by: Daniel Rammer <[email protected]> * udpated dockerfile go template to reflect current master fixing rebase overwrites Signed-off-by: Daniel Rammer <[email protected]> * and again .. with a space Signed-off-by: Daniel Rammer <[email protected]> * add docs on exports Signed-off-by: Daniel Rammer <[email protected]> * changed configuration to use config.Duration from flytestdlib instead of defining on seconds Signed-off-by: Daniel Rammer <[email protected]> * added owner id to reservation gorm impl delete function Signed-off-by: Daniel Rammer <[email protected]> * if reservation is missing on release reservation (meaning another entity acquired it) then gracefully fail Signed-off-by: Daniel Rammer <[email protected]> * updated flyteidl version Signed-off-by: Daniel Rammer <[email protected]> * remove flyteidl replace in go.mod and updating to latest version Signed-off-by: Daniel Rammer <[email protected]> Co-authored-by: Chao-Han Tsai <[email protected]> Co-authored-by: Yuvraj <[email protected]> Co-authored-by: Samhita Alla <[email protected]> Co-authored-by: Haytham Abuelfutuh <[email protected]>
eapolinario
pushed a commit
that referenced
this issue
Sep 8, 2023
* Separating Workflow Metadata and Defaults * make generate Co-authored-by: Miguel Toledo <[email protected]>
eapolinario
pushed a commit
that referenced
this issue
Sep 12, 2023
eapolinario
pushed a commit
that referenced
this issue
Sep 13, 2023
* Separating Workflow Metadata and Defaults * make generate Co-authored-by: Miguel Toledo <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]>
pvditt
pushed a commit
that referenced
this issue
Dec 29, 2023
* Separating Workflow Metadata and Defaults * make generate Co-authored-by: Miguel Toledo <[email protected]>
pmahindrakar-oss
pushed a commit
that referenced
this issue
Feb 5, 2024
Merge flyteorg/flyte 'v1.10.7-b2'
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Apr 30, 2024
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Apr 30, 2024
austin362667
pushed a commit
to austin362667/flyte
that referenced
this issue
May 7, 2024
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this issue
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now if a container is misconfigured or something, the job sticks around forever. Propeller should garbage collect and fail.
The text was updated successfully, but these errors were encountered: