Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] flyte-cli and flyteadmin have different representation of certain filters #418

Closed
2 of 13 tasks
kumare3 opened this issue Jul 20, 2020 · 2 comments
Closed
2 of 13 tasks

[BUG] flyte-cli and flyteadmin have different representation of certain filters #418

kumare3 opened this issue Jul 20, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@kumare3
Copy link
Contributor

kumare3 commented Jul 20, 2020

Describe the bug
using flyte-cli to write filters is extremely hard because of no documentation. ALso in the case of "not equals" both expect different syntax - https://github.com/lyft/flyteadmin/blob/45a79dba5a0c64b431263f53d7640af8a8ec8d20/pkg/common/filters.go#L72 (Admin wants ne)
Flytekit wants "neq"

Expected behavior
Documentation should have example of each filter.
And filters should be consistent

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other
@kumare3 kumare3 added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Jul 20, 2020
@honnix honnix mentioned this issue Dec 3, 2020
Merged
8 tasks
@honnix
Copy link
Member

honnix commented Dec 4, 2020

Trying to address this issue in the referencing PR, where I changed neq to ne in flytekit because I consider it to be never working so it won't break anything, while keeping the API side unchanged for backward compatibility.

@honnix honnix removed the untriaged This issues has not yet been looked at by the Maintainers label Dec 4, 2020
@honnix
Copy link
Member

honnix commented Dec 11, 2020

closed by flyteorg/flytekit#272

@honnix honnix closed this as completed Dec 11, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@katrogan
Send IsParent & IsDynamic in node execution events (flyteorg#418)
d46758a
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@katrogan
Update flytestdlib to v1.0.2 (flyteorg#418)
4f7ee9c
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@SandraGH5
Update pytorch_single_node_multi_gpu.py (flyteorg#418)
349f885 
Embedding a video explaining Single-node Multiple-GPU training.
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@olga-union
chore: update react-flow-renderer version (flyteorg#418)
14c373b 
Signed-off-by: Olga Nad <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@katrogan
Send IsParent & IsDynamic in node execution events (flyteorg#418)
f475c6c
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@katrogan
Update flytestdlib to v1.0.2 (flyteorg#418)
8024632
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@honnix @kumare3