Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]FlyteConsole Launch Form should allow Schema Type #405

Closed
1 of 13 tasks
kumare3 opened this issue Jul 9, 2020 · 3 comments
Closed
1 of 13 tasks

[Feature]FlyteConsole Launch Form should allow Schema Type #405

kumare3 opened this issue Jul 9, 2020 · 3 comments
Assignees
@schottra
Labels
enhancement New feature or request ui Admin console user interface
Milestone
0.9.0

Comments

@kumare3
Copy link
Contributor

kumare3 commented Jul 9, 2020

Motivation: Why do you think this is important?
Schema Type is a typed variant of MultiPart Blob Type. Thus the console could simply support Schema Type "uri" input as defined here . The "type" information is already part of the Variable declaration which is parsed by the UI.

Goal: What should the final outcome look like, ideally?
A user should be allowed to enter a simple URI link. The URI should be a prefix (not a file), just like a multi-part blob. No other validation is necessary

Describe alternatives you've considered
None

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

Additional context
NA

Is this a blocker for you to adopt Flyte
NA
@kumare3 kumare3 added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Jul 9, 2020
@kumare3
Copy link
Contributor Author

kumare3 commented Jul 9, 2020

@schottra FYI!

@schottra
Copy link
Contributor

This is a subset of #22. I'll keep this around so it can be closed separately when schema is implemented.

@schottra schottra added this to the 0.9.0 milestone Oct 20, 2020
@schottra schottra added ui Admin console user interface and removed untriaged This issues has not yet been looked at by the Maintainers labels Oct 20, 2020
@schottra schottra self-assigned this Oct 20, 2020
@schottra schottra mentioned this issue Oct 22, 2020
Merged
7 tasks
@schottra
Copy link
Contributor

Implemented by flyteorg/flyteconsole#110
Available in flyteconsole v0.16.0

@schottra schottra closed this as completed Nov 4, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@hamersaw
Only require default plugin configuration for task types with multipl…
c1bf6d5 
…e registered plugins (flyteorg#405)

* task types with only one registered plugin use it - otherwise declare default plugin in config

Signed-off-by: Daniel Rammer <[email protected]>

* fixed test and lint issues

Signed-off-by: Daniel Rammer <[email protected]>

* updated task-config flags

Signed-off-by: Daniel Rammer <[email protected]>

* converted to named return values

Signed-off-by: Daniel Rammer <[email protected]>

* failing to initialize plugins on nil TaskConfig

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteplugins version

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteplugins to merged version

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@pmahindrakar-oss
Added missing metrics for launchplanidkey and phase (flyteorg#405)
91787d2
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@samhita-alla
fix algolia search (flyteorg#405)
c9f71fe 
Signed-off-by: Samhita Alla <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@hamersaw
Only require default plugin configuration for task types with multipl…
e30da6f 
…e registered plugins (flyteorg#405)

* task types with only one registered plugin use it - otherwise declare default plugin in config

Signed-off-by: Daniel Rammer <[email protected]>

* fixed test and lint issues

Signed-off-by: Daniel Rammer <[email protected]>

* updated task-config flags

Signed-off-by: Daniel Rammer <[email protected]>

* converted to named return values

Signed-off-by: Daniel Rammer <[email protected]>

* failing to initialize plugins on nil TaskConfig

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteplugins version

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteplugins to merged version

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@pmahindrakar-oss
Added missing metrics for launchplanidkey and phase (flyteorg#405)
44b6f16
eapolinario pushed a commit that referenced this issue Sep 8, 2023
@ByronHsu
Add oauth2 http proxy client (#405)
3e10bb8 
Signed-off-by: byhsu <[email protected]>
eapolinario pushed a commit that referenced this issue Sep 13, 2023
@ByronHsu @eapolinario
Add oauth2 http proxy client (#405)
caff6a2 
Signed-off-by: byhsu <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario pushed a commit that referenced this issue Sep 26, 2023
@EngHabu
Add ray dashboard log link (#405)
66e7b64 
* Add ray dashboard log link

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* A few fixes

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* lint

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* lint

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Add EnableUsageStats start parameter

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Add more tests

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* more tests

Signed-off-by: Haytham Abuelfutuh <[email protected]>

---------

Signed-off-by: Haytham Abuelfutuh <[email protected]>
pvditt pushed a commit that referenced this issue Dec 29, 2023
@ByronHsu
Add oauth2 http proxy client (#405)
dae6d23 
Signed-off-by: byhsu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schottra schottra

Labels
enhancement New feature or request ui Admin console user interface
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
2 participants
@schottra @kumare3