Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix or enhance failure to catalog errors in propeller #365

Closed
3 of 20 tasks
wild-endeavor opened this issue Jun 24, 2020 · 1 comment
Closed
3 of 20 tasks

[BUG] Fix or enhance failure to catalog errors in propeller #365

wild-endeavor opened this issue Jun 24, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@wild-endeavor
Copy link
Contributor

wild-endeavor commented Jun 24, 2020

Describe the bug
Sometimes, we'll see this log line in propeller

Error putting to catalog [failed to create dataset for ID resource_type:TASK project:"asdf" domain:"production" name:"app.workflows.asdfasdf" version:"fdsafsdf" : rpc error: code = InvalidArgument desc = missing artifactData]

(See the internal link in our on-call notes for an example execution.)

Note that the execution succeeded. In fact, there is no indication that it did not cache.

We should

  1. Figure out why this error is happening, and fix it if it's something broken on our end.
  2. If not, then we should return an error to the user, possibly failing the workflow.
  3. Even if we don't fail the entire workflow, we should somehow make it clear to the user that it failed to cache.

Expected behavior
See above.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
Not sure.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment
Flyte component

  • Sandbox (local or on one machine)
  • Cloud hosted
    • AWS
    • GCP
    • Azure
  • Baremetal
  • Other
@wild-endeavor wild-endeavor added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Jun 24, 2020
@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Jan 29, 2021
@EngHabu
Copy link
Contributor

EngHabu commented Aug 31, 2021

I think our window of investigation might have closed... will investigate further if it comes up again..

@EngHabu EngHabu closed this as completed Aug 31, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
Signed-off-by: Flyte-Bot <[email protected]>

Co-authored-by: flyte-bot <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
Signed-off-by: Flyte-Bot <[email protected]>

Co-authored-by: evalsocket <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
Bumps [moment](https://github.com/moment/moment) from 2.29.1 to 2.29.2.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](moment/moment@2.29.1...2.29.2)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
Signed-off-by: Flyte-Bot <[email protected]>

Co-authored-by: flyte-bot <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
Signed-off-by: Flyte-Bot <[email protected]>

Co-authored-by: evalsocket <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants