Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editing of descriptions via the UI #3532

Open
schottra opened this issue Dec 13, 2019 · 13 comments
Open

Allow editing of descriptions via the UI #3532

schottra opened this issue Dec 13, 2019 · 13 comments
Labels
blocked This work depends on an upstream change enhancement New feature or request stale ui Admin console user interface

Comments

@schottra
Copy link
Contributor

schottra commented Dec 13, 2019

Projects, Workflows, Launch Plans, and Tasks can all have descriptions associated with them. There are endpoints that allow setting these values. But currently there is no UX for doing so in the Console.

A basic implementation would be the click-to-edit pencil which saves on blur.

Before editing (pencil icon)
image

Edit state with cancel/save buttons
image

Display of save errors goes below the buttons
image

@schottra schottra added enhancement New feature or request ui Admin console user interface labels Dec 13, 2019
@schottra schottra self-assigned this Dec 13, 2019
@hisergiorojas
Copy link

May I work on this issue.

@schottra
Copy link
Contributor Author

Hi @hisergiorojas! Contributions are welcome. I've updated the issue description with some mockups depicting the desired behavior. Feel free to contact me on Slack if you have any questions.

@kumare3
Copy link
Contributor

kumare3 commented Mar 30, 2020

@hisergiorojas are you working on this issue?

@hisergiorojas
Copy link

@kumare3 Yes

@kumare3
Copy link
Contributor

kumare3 commented Apr 25, 2020

@hisergiorojas thank you so much, do you think we will have this by month end? If not should we push it to the next release?

@kumare3 kumare3 added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 6, 2020
@keshann93
Copy link

Hi @kumare3, I am new to flyte but would like to give it a try to implement edit feature

@kumare3
Copy link
Contributor

kumare3 commented Dec 23, 2020

@keshann93 absolutely - go for it. We maybe updating our backed descriptions capturing but this will not change. Thank you!

@EngHabu
Copy link
Contributor

EngHabu commented Jan 29, 2021

@keshann93, I'm doing a sweep on the existing bugs.. Is this something you can look at soon? It would really help our overall UX story.

@welcome
Copy link

welcome bot commented Apr 19, 2022

Thank you for opening your first issue here! 🛠

@anrusina anrusina transferred this issue from flyteorg/flyte Apr 19, 2022
@anrusina anrusina added untriaged This issues has not yet been looked at by the Maintainers and removed help wanted Extra attention is needed labels Apr 19, 2022
@anrusina anrusina added the blocked This work depends on an upstream change label Apr 27, 2022
@anrusina
Copy link

BLocked as description value is not populated properly at this time

@flixr
Copy link
Contributor

flixr commented Nov 19, 2022

Is this still planed? What is blocking it?

@kumare3
Copy link
Contributor

kumare3 commented Nov 19, 2022

Resourcing- contributions welcome

@cosmicBboy cosmicBboy transferred this issue from flyteorg/flyteconsole Mar 24, 2023
@eapolinario eapolinario removed untriaged This issues has not yet been looked at by the Maintainers good first issue Good for newcomers labels Dec 22, 2023
Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This work depends on an upstream change enhancement New feature or request stale ui Admin console user interface
Projects
None yet
Development

No branches or pull requests

8 participants