-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Investigation] Understand latency of Admin list task executions #328
Comments
EngHabu
added
bug
Something isn't working
untriaged
This issues has not yet been looked at by the Maintainers
labels
May 27, 2020
wild-endeavor
changed the title
[Investigation] Flyte Admin 95th Percentile read latency is bursty
[Investigation] Understand latency of Admin list task executions
Jun 27, 2020
20 tasks
For context (thank you @anandswaminathan for the pointers) the list task executions for node query was querying on a subset of primary key fields (execution project, execution domain, execution name, node id) that were not indexed. Adding an index for this use case brought down query latency from the order of seconds to ~0.1 ms |
8 tasks
wild-endeavor
removed
the
untriaged
This issues has not yet been looked at by the Maintainers
label
Sep 2, 2020
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Dec 6, 2022
* CRD validation Signed-off-by: Kevin Su <[email protected]> * CRD validation Signed-off-by: Kevin Su <[email protected]> * Revert json tag name Signed-off-by: Kevin Su <[email protected]> * Address comment Signed-off-by: Kevin Su <[email protected]> * Address comment Signed-off-by: Kevin Su <[email protected]> * Fixed test Signed-off-by: Kevin Su <[email protected]> * Rebase Signed-off-by: Kevin Su <[email protected]> * Updated CRD Signed-off-by: Kevin Su <[email protected]> * test Signed-off-by: Kevin Su <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Dec 6, 2022
)" (flyteorg#355) This reverts commit 02f2ad9. Signed-off-by: Haytham Abuelfutuh <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Dec 20, 2022
…w standart #patch (flyteorg#328) * chore: update eslint and prettier, use arbnb rules as base for standart * chore: prettier run through p.1 - p8 * chore: eslint shuffle imports * chore: eslint set few rules to warn, so we can start working on them Signed-off-by: Nastya Rusina <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Dec 20, 2022
Signed-off-by: Prafulla Mahindrakar <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Aug 9, 2023
* CRD validation Signed-off-by: Kevin Su <[email protected]> * CRD validation Signed-off-by: Kevin Su <[email protected]> * Revert json tag name Signed-off-by: Kevin Su <[email protected]> * Address comment Signed-off-by: Kevin Su <[email protected]> * Address comment Signed-off-by: Kevin Su <[email protected]> * Fixed test Signed-off-by: Kevin Su <[email protected]> * Rebase Signed-off-by: Kevin Su <[email protected]> * Updated CRD Signed-off-by: Kevin Su <[email protected]> * test Signed-off-by: Kevin Su <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Aug 9, 2023
)" (flyteorg#355) This reverts commit 0cac412. Signed-off-by: Haytham Abuelfutuh <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Apr 30, 2024
Signed-off-by: Prafulla Mahindrakar <[email protected]>
austin362667
pushed a commit
to austin362667/flyte
that referenced
this issue
May 7, 2024
Signed-off-by: Prafulla Mahindrakar <[email protected]>
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this issue
Jul 2, 2024
Signed-off-by: Prafulla Mahindrakar <[email protected]>
troychiu
pushed a commit
that referenced
this issue
Jul 8, 2024
## Overview This PR adds support for managing orphaned pods. This is an extreme corner-case, that may be impossible, but will ensure we do not orphan pods when GCing fasttask environments. ## Test Plan This was tested locally and added unit tests. ## Rollout Plan (if applicable) May be rolled out immediately. ## Upstream Changes Should this change be upstreamed to OSS (flyteorg/flyte)? If not, please uncheck this box, which is used for auditing. Note, it is the responsibility of each developer to actually upstream their changes. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F). - [ ] To be upstreamed to OSS ## Issue https://linear.app/unionai/issue/COR-993/support-adding-pods-to-an-orphaned-environment ## Checklist * [x] Added tests * [ ] Ran a deploy dry run and shared the terraform plan * [ ] Added logging and metrics * [ ] Updated [dashboards](https://unionai.grafana.net/dashboards) and [alerts](https://unionai.grafana.net/alerting/list) * [x] Updated documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
LIst task executions is slow. We should figure out why and improve performance. If performance cannot be improved, then we need to figure out a better solution.
Expected behavior
This query should (we think) be faster than it is. It's taking about a second, which is much too slow.
Anand and Katrina have already looked through the query plan and nothing looks amiss. All the right indices are being hit. Debugging this and understanding if we have a fundamental problem with our data model will require a deeper look than just going through the query plan.
Flyte component
To Reproduce
Steps to reproduce the behavior:
Screenshots
If applicable, add screenshots to help explain your problem.
Environment
Flyte component
Additional context
NA
The text was updated successfully, but these errors were encountered: