Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Non-blocking rate-limiter #241

Closed
3 of 13 tasks
wild-endeavor opened this issue Apr 3, 2020 · 3 comments
Closed
3 of 13 tasks

[Feature] Non-blocking rate-limiter #241

wild-endeavor opened this issue Apr 3, 2020 · 3 comments
Labels
enhancement New feature or request stale untriaged This issues has not yet been looked at by the Maintainers

Comments

@wild-endeavor
Copy link
Contributor

wild-endeavor commented Apr 3, 2020

Motivation: Why do you think this is important?
The rate limiter in flytestdlib is currently a blocking one. We should add a new one that's non-blocking, move all invocations to the new one, and then deprecate the blocking one.

Goal: What should the final outcome look like, ideally?
Non-blocking rate limiter is used across Flyte components like plugins and propeller.

Describe alternatives you've considered
None.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other
@wild-endeavor wild-endeavor added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Apr 3, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
* github action and readthedocs config

Signed-off-by: Samhita Alla <[email protected]>

* dummy push

Signed-off-by: Samhita Alla <[email protected]>

* modify github action trigger

Signed-off-by: Samhita Alla <[email protected]>

* modify github action

Signed-off-by: Samhita Alla <[email protected]>

* modify github action

Signed-off-by: Samhita Alla <[email protected]>

* added SSH

Signed-off-by: Samhita Alla <[email protected]>

* added SSH

Signed-off-by: Samhita Alla <[email protected]>

* modify furo repo install

Signed-off-by: Samhita Alla <[email protected]>

* Squash commits

parent 221c6f2fca4ae20ee50d938da2a8795cc182965d
author Samhita Alla <[email protected]> 1621593398 +0530
committer Samhita Alla <[email protected]> 1621614185 +0530

furo repo install

Signed-off-by: Samhita Alla <[email protected]>

furo repo install

Signed-off-by: Samhita Alla <[email protected]>

furo repo install

Signed-off-by: Samhita Alla <[email protected]>

furo repo install

Signed-off-by: Samhita Alla <[email protected]>

modified requirements.txt

Signed-off-by: Samhita Alla <[email protected]>

sphinx build command

Signed-off-by: Samhita Alla <[email protected]>

install git

Signed-off-by: Samhita Alla <[email protected]>

install git

Signed-off-by: Samhita Alla <[email protected]>

install git

Signed-off-by: Samhita Alla <[email protected]>

install git

Signed-off-by: Samhita Alla <[email protected]>

install git

Signed-off-by: Samhita Alla <[email protected]>

install git

Signed-off-by: Samhita Alla <[email protected]>

install git

Signed-off-by: Samhita Alla <[email protected]>

modify workflow

Signed-off-by: Samhita Alla <[email protected]>

modify workflow

Signed-off-by: Samhita Alla <[email protected]>

modify workflow

Signed-off-by: Samhita Alla <[email protected]>

modify python version

Signed-off-by: Samhita Alla <[email protected]>

modify python version

Signed-off-by: Samhita Alla <[email protected]>

added change directory

Signed-off-by: Samhita Alla <[email protected]>

added matplotlib

Signed-off-by: Samhita Alla <[email protected]>

added flytekit

Signed-off-by: Samhita Alla <[email protected]>

added sphinx rli

Signed-off-by: Samhita Alla <[email protected]>

deployment

Signed-off-by: Samhita Alla <[email protected]>

deploy

Signed-off-by: Samhita Alla <[email protected]>

deploy

Signed-off-by: Samhita Alla <[email protected]>

dummy push

Signed-off-by: Samhita Alla <[email protected]>

archive HTML files

Signed-off-by: Samhita Alla <[email protected]>

cleaned github action

Signed-off-by: Samhita Alla <[email protected]>

modified the artifact path

Signed-off-by: Samhita Alla <[email protected]>

modified the artifact path

Signed-off-by: Samhita Alla <[email protected]>

modified the artifact path

Signed-off-by: Samhita Alla <[email protected]>

modified the artifact path

Signed-off-by: Samhita Alla <[email protected]>

modified the artifact path

Signed-off-by: Samhita Alla <[email protected]>

modified the artifact path

Signed-off-by: Samhita Alla <[email protected]>

modified artifact and sphinx build command

Signed-off-by: Samhita Alla <[email protected]>

modified artifact files

Signed-off-by: Samhita Alla <[email protected]>

modified artifact files

Signed-off-by: Samhita Alla <[email protected]>

modified artifact files

Signed-off-by: Samhita Alla <[email protected]>

modified artifact files

Signed-off-by: Samhita Alla <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
* PR to bump

Signed-off-by: Ketan Umare <[email protected]>

* updated

Signed-off-by: Ketan Umare <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
* Fix flytectl ux issue

Signed-off-by: Yuvraj <[email protected]>
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Aug 26, 2023
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@kumare3
Copy link
Contributor

kumare3 commented Dec 22, 2023

this is not used by users and we will keep iterating.

@kumare3 kumare3 closed this as completed Dec 22, 2023
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
* Fix flytectl ux issue

Signed-off-by: Yuvraj <[email protected]>
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
* Fix flytectl ux issue

Signed-off-by: Yuvraj <[email protected]>
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
* Fix flytectl ux issue

Signed-off-by: Yuvraj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Development

No branches or pull requests

3 participants