Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test issue 2 #17

Closed
georgesnelling opened this issue Nov 16, 2019 · 1 comment
Closed

test issue 2 #17

georgesnelling opened this issue Nov 16, 2019 · 1 comment
Assignees
Labels

Comments

@georgesnelling
Copy link
Contributor

test issue

@EngHabu
Copy link
Contributor

EngHabu commented Nov 17, 2019

This is a very important issue.. it touches compliance!

@EngHabu EngHabu closed this as completed Nov 22, 2019
eapolinario referenced this issue in eapolinario/flyte Dec 6, 2022
* Fix dynamic WF marshalling

* Update unit tests

* add unit test
eapolinario referenced this issue in eapolinario/flyte Dec 6, 2022
* Sign on minio

* missing
eapolinario referenced this issue in eapolinario/flyte Dec 20, 2022
* Allow InitializePFlags to recursively discover sub-section flags

* Add unit test
eapolinario referenced this issue in eapolinario/flyte Dec 20, 2022
The project title - `Flyte CoPilot` was not rendering
properly in Markdown because of a missing space.

Signed-off-by: Tanay Tummalpalli <[email protected]>
eapolinario referenced this issue in eapolinario/flyte Aug 9, 2023
* Fix dynamic WF marshalling

* Update unit tests

* add unit test
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
* Allow InitializePFlags to recursively discover sub-section flags

* Add unit test
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
* Sign on minio

* missing
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
The project title - `Flyte CoPilot` was not rendering
properly in Markdown because of a missing space.

Signed-off-by: Tanay Tummalpalli <[email protected]>
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
This addresses a TODO in `update.sh` to allow a more freeform
`update.cfg`. With this change, `update.cfg` will:

- Tolerate and ignore blank/whitespace-only lines
- Tolerate `#` style comments, both inline (as long as preceded by
  whitespace) and whole-line.
- Validate directories more prettily, failing with a useful message if
  one doesn't exist.
- Explicitly disallow multiple entries per line, with a useful message.

(Previously these last two things would still error, just more
confusingly.)

While in there, I also added an `EXIT` trap to remove the temporary
directory, since otherwise failures mid-script would leave it hanging
around, gradually polluting `/tmp`.

Signed-off-by: Eric Fried <[email protected]>
eapolinario pushed a commit that referenced this issue Sep 12, 2023
eapolinario pushed a commit that referenced this issue Apr 30, 2024
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants