Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private/Custom UI components #146

Closed
schottra opened this issue Dec 13, 2019 · 2 comments
Closed

Private/Custom UI components #146

schottra opened this issue Dec 13, 2019 · 2 comments
Labels
enhancement New feature or request ui Admin console user interface

Comments

@schottra
Copy link
Contributor

It might be useful for the UI to support private/custom UI components that are installed/loaded at runtime. There are a couple of use cases:

  • Flyte users can write custom tasks that produce custom output. To the UI, this output is just an object with no semantic meaning to the fields. But a custom UI plugin might be able to render that output in a more useful way
  • Some users/companies may have a desire to show related/linked metrics for an Execution as additional tabs in the ExecutionDetails view (next to the Nodes/Graph tabs). Those custom views might reach out to internal, private systems for their data.

From the standpoint of Flyte Console, we merely need to know that these plugins exist and give them space/data to do their work. My initial thought is that it makes sense to define a React Component interface for each case where we allow extensions/overrides, document those, and maybe create a sandbox to let people play around in for testing.
"Installation" of the component could be including a script/bundle that calls a global function to install the hooks. This needs a little more definition.

@schottra schottra added enhancement New feature or request ui Admin console user interface labels Dec 13, 2019
@schottra schottra self-assigned this Dec 13, 2019
@schottra schottra added the pri1 label Dec 13, 2019
@schottra schottra added this to the 2019-12-20 milestone Dec 13, 2019
@schottra schottra added pri3 and removed pri1 labels Jan 10, 2020
@kumare3 kumare3 modified the milestones: 0.2.0, 0.3.0 Mar 31, 2020
@kumare3 kumare3 modified the milestones: 0.3.0, 0.4.0, 0.5.0 Apr 25, 2020
@EngHabu EngHabu removed this from the 0.5.0 milestone Jun 25, 2020
@schottra schottra added later and removed pri3 labels Jul 6, 2020
@schottra schottra removed their assignment Jul 6, 2020
@EngHabu
Copy link
Contributor

EngHabu commented Jan 29, 2021

Bug bankruptcy

@kumare3 kumare3 removed the later label Feb 8, 2021
@anrusina
Copy link

FlyteDeck should solve it, not needed due to https://github.com/flyteorg/flyteconsole/issues/469

eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
…lyteorg#146)

* Capped retries for all failures and allowing backoff queue

* lint fix
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
* Move scopes to config

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* missed

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* wip

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update handlers.go

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* go get propeller at v0.5.12 (flyteorg#146)

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update to using latest flytepropeller v0.5.13 (flyteorg#148)

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update propeller to 0.5.14 (flyteorg#149)

* Update propeller

* cleanup

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Filter executions by user (flyteorg#150)

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update CI post migration

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update codecov link

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Publish raw events (flyteorg#151)

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* fix test

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* wip

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Fix token retrieval from cookies

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Fix unit tests and lint

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Move to const

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Revert Auth config

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Revert kube config path

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Use access token when posting to IdP

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Ignore refresh token error

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Fix tests

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Expose openId metadata endpoint and expose scopes in /config endpoint

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* mod tidy

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* rename

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* lint

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* unit tests

Signed-off-by: Haytham Abuelfutuh <[email protected]>

Co-authored-by: Yee Hing Tong <[email protected]>
Co-authored-by: Katrina Rogan <[email protected]>
Co-authored-by: tnsetting <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
…yteorg#146)

* Proposal: Common plugin interface for all service plugins
* Add remote plugin interface and implemention
* make properties config-friendly
* Rename remote.PluginContext
* Simplify ResourceMeta
* New task log interface and template plugin
* Update spark and pytorch plugins
* Proposal: Common plugin interface for all service plugins


Co-authored-by: Ketan Umare <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
Signed-off-by: Flyte-Bot <[email protected]>

Co-authored-by: kumare3 <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
…lyteorg#146)

* Capped retries for all failures and allowing backoff queue

* lint fix
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
…yteorg#146)

* Proposal: Common plugin interface for all service plugins
* Add remote plugin interface and implemention
* make properties config-friendly
* Rename remote.PluginContext
* Simplify ResourceMeta
* New task log interface and template plugin
* Update spark and pytorch plugins
* Proposal: Common plugin interface for all service plugins


Co-authored-by: Ketan Umare <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
* Move scopes to config

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* missed

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* wip

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update handlers.go

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* go get propeller at v0.5.12 (flyteorg#146)

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update to using latest flytepropeller v0.5.13 (flyteorg#148)

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update propeller to 0.5.14 (flyteorg#149)

* Update propeller

* cleanup

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Filter executions by user (flyteorg#150)

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update CI post migration

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update codecov link

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Publish raw events (flyteorg#151)

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* fix test

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* wip

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Fix token retrieval from cookies

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Fix unit tests and lint

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Move to const

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Revert Auth config

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Revert kube config path

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Use access token when posting to IdP

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Ignore refresh token error

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Fix tests

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Expose openId metadata endpoint and expose scopes in /config endpoint

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* mod tidy

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* rename

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* lint

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* unit tests

Signed-off-by: Haytham Abuelfutuh <[email protected]>

Co-authored-by: Yee Hing Tong <[email protected]>
Co-authored-by: Katrina Rogan <[email protected]>
Co-authored-by: tnsetting <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
Signed-off-by: Flyte-Bot <[email protected]>

Co-authored-by: kumare3 <[email protected]>
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
Signed-off-by: Flyte-Bot <[email protected]>

Co-authored-by: kumare3 <[email protected]>
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
Signed-off-by: Flyte-Bot <[email protected]>

Co-authored-by: kumare3 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui Admin console user interface
Projects
None yet
Development

No branches or pull requests

4 participants