Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Upgrade to apiextensions.k8s.io/v1 CustomResourceDefinition in deployment resources (prepare for v1.22+) #1273

Open
brucearctor opened this issue Jul 22, 2021 · 6 comments
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free stale

Comments

@brucearctor
Copy link
Contributor

Describe the bug
Warning: apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition is pointed out when running Kustomize deployment

Expected behavior
Current version of K8s is 1.21 -- we should upgrade that to refer to rbac.authorization.k8s.io/v1 by v.1.22+ release

@brucearctor brucearctor added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Jul 22, 2021
@manuelrombach
Copy link
Contributor

The same goes for Ingress API:
networking.k8s.io/v1beta1 Ingress is deprecated in v1.19+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress

@pradithya
Copy link
Member

Warning when deploying flyte gave us list removed apis in 1.22

W1102 03:48:56.655502     110 warnings.go:70] apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition
W1102 03:48:56.660052     110 warnings.go:70] apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition
W1102 03:48:56.688648     110 warnings.go:70] apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition
W1102 03:48:56.713382     110 warnings.go:70] apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition
W1102 03:48:56.718868     110 warnings.go:70] apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition
W1102 03:48:56.748158     110 warnings.go:70] apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition
W1102 03:48:57.366469     110 warnings.go:70] rbac.authorization.k8s.io/v1beta1 ClusterRoleBinding is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRoleBinding
W1102 03:48:57.371235     110 warnings.go:70] rbac.authorization.k8s.io/v1beta1 ClusterRoleBinding is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRoleBinding
W1102 03:48:57.413321     110 warnings.go:70] rbac.authorization.k8s.io/v1beta1 ClusterRoleBinding is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRoleBinding
W1102 03:48:57.433966     110 warnings.go:70] rbac.authorization.k8s.io/v1beta1 ClusterRoleBinding is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRoleBinding
W1102 03:48:57.441407     110 warnings.go:70] rbac.authorization.k8s.io/v1beta1 ClusterRoleBinding is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRoleBinding
W1102 03:48:57.483823     110 warnings.go:70] rbac.authorization.k8s.io/v1beta1 ClusterRoleBinding is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRoleBinding
W1102 03:48:57.534505     110 warnings.go:70] rbac.authorization.k8s.io/v1beta1 ClusterRoleBinding is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRoleBinding
W1102 03:48:57.538594     110 warnings.go:70] rbac.authorization.k8s.io/v1beta1 ClusterRoleBinding is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRoleBinding
W1102 03:48:57.593240     110 warnings.go:70] rbac.authorization.k8s.io/v1beta1 ClusterRoleBinding is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRoleBinding
W1102 03:48:58.661888     110 warnings.go:70] networking.k8s.io/v1beta1 Ingress is deprecated in v1.19+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
W1102 03:48:58.666369     110 warnings.go:70] networking.k8s.io/v1beta1 Ingress is deprecated in v1.19+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
W1102 03:48:58.698138     110 warnings.go:70] networking.k8s.io/v1beta1 Ingress is deprecated in v1.19+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress

fsz285 pushed a commit to fsz285/flyte that referenced this issue Dec 21, 2021
The CRD for the flyteworkflows is incomplete, atm. A schema should be
added in the near future.

See flyteorg#1273
fsz285 pushed a commit to fsz285/flyte that referenced this issue Dec 21, 2021
The CRD for the flyteworkflows is incomplete, atm. A schema should be
added in the near future.

See flyteorg#1273

Signed-off-by: ferdinand.szekeresch <[email protected]>
fsz285 pushed a commit to fsz285/flyte that referenced this issue Dec 21, 2021
The CRD for the flyteworkflows is incomplete, atm. A schema should be
added in the near future.

See flyteorg#1273

Signed-off-by: ferdinand.szekeresch <[email protected]>
@sbrunk
Copy link
Member

sbrunk commented Dec 22, 2021

We switched back to ingress in #988 but now 1.18 is nearing EOL while 1.22 is available in the GKE rapid channel, moving to the regular channel in 2022-02 and will be available in EKS in March 2022. Docker Desktop is also on 1.22 already.

So the question is if people are still using 1.18 or if we can switch over to networking.k8s.io/v1?

Adding @EngHabu @kumare3 because I guess you know best who else to ask. Also @juandiegopalomino because you did #988

EngHabu pushed a commit that referenced this issue Jan 26, 2022
* Update apis to allow for compatibility with k8s 1.22

The CRD for the flyteworkflows is incomplete, atm. A schema should be
added in the near future.

See #1273

Signed-off-by: ferdinand.szekeresch <[email protected]>

* Run make helm

Signed-off-by: Sören Brunk <[email protected]>

* Set x-kubernetes-preserve-unknown-fields to true

Required to prevent pruning of fields by the API server until we have a
schema for workflows.

Signed-off-by: Sören Brunk <[email protected]>

Co-authored-by: ferdinand.szekeresch <[email protected]>
Co-authored-by: Sören Brunk <[email protected]>
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Aug 26, 2023
@github-actions
Copy link

github-actions bot commented Sep 3, 2023

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@github-actions github-actions bot removed the stale label Nov 3, 2023
Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free stale
Projects
None yet
Development

No branches or pull requests

5 participants