Update helm/docs per changes in supported task discovery

Signed-off-by: Jason Parraga <[email protected]>
flyteorg · Aug 26, 2024 · db28350 · db28350
1 parent 7d59f10
commit db28350
Show file tree

Hide file tree

Showing 16 changed files with 12 additions and 93 deletions.
diff --git a/charts/flyte-core/README.md b/charts/flyte-core/README.md
@@ -195,11 +195,11 @@ helm install gateway bitnami/contour -n flyte
 | flyteadmin.serviceMonitor.scrapeTimeout | string | `"30s"` | Sets the timeout after which request to scrape metrics will time out |
 | flyteadmin.tolerations | list | `[]` | tolerations for Flyteadmin deployment |
 | flyteagent.enabled | bool | `false` |  |
-| flyteagent.plugin_config.plugins.agent-service | object | `{"defaultAgent":{"endpoint":"dns:///flyteagent.flyte.svc.cluster.local:8000","insecure":true},"supportedTaskTypes":["sensor"]}` | Agent service configuration for propeller. |
+| flyteagent.plugin_config.plugins.agent-service | object | `{"defaultAgent":{"endpoint":"dns:///flyteagent.flyte.svc.cluster.local:8000","insecure":true},"supportedTaskTypes":[]}` | Agent service configuration for propeller. |
 | flyteagent.plugin_config.plugins.agent-service.defaultAgent | object | `{"endpoint":"dns:///flyteagent.flyte.svc.cluster.local:8000","insecure":true}` | The default agent service to use for plugin tasks. |
 | flyteagent.plugin_config.plugins.agent-service.defaultAgent.endpoint | string | `"dns:///flyteagent.flyte.svc.cluster.local:8000"` | The agent service endpoint propeller should connect to. |
 | flyteagent.plugin_config.plugins.agent-service.defaultAgent.insecure | bool | `true` | Whether the connection from propeller to the agent service should use TLS. |
-| flyteagent.plugin_config.plugins.agent-service.supportedTaskTypes | list | `["sensor"]` | The task types supported by the default agent. |
+| flyteagent.plugin_config.plugins.agent-service.supportedTaskTypes | list | `[]` | The task types supported by the default agent. As of #5460 these are discovered automatically and don't need to be configured. |
 | flyteagent.podLabels | object | `{}` | Labels for flyteagent pods |
 | flyteconsole.affinity | object | `{}` | affinity for Flyteconsole deployment |
 | flyteconsole.enabled | bool | `true` |  |

diff --git a/charts/flyte-core/values.yaml b/charts/flyte-core/values.yaml
@@ -287,11 +287,9 @@ flyteagent:
           endpoint: "dns:///flyteagent.flyte.svc.cluster.local:8000"
           # -- Whether the connection from propeller to the agent service should use TLS.
           insecure: true
-        # -- The task types supported by the default agent.
-        supportedTaskTypes:
-        - sensor
-        # -- Uncomment to enable task type that uses Flyte Agent
-        # - bigquery_query_job_task
+        # -- The task types supported by the default agent. As of #5460 these are discovered automatically and don't
+        # need to be configured.
+        supportedTaskTypes: []
   # -- Labels for flyteagent pods
   podLabels: {}
 

diff --git a/docker/sandbox-bundled/manifests/complete-agent.yaml b/docker/sandbox-bundled/manifests/complete-agent.yaml
@@ -817,7 +817,7 @@ type: Opaque
 ---
 apiVersion: v1
 data:
-  haSharedSecret: dkJZdnpKQ0FYZkhWano2eg==
+  haSharedSecret: ZHg2VFNJWXNrdG9YVEhvZA==
   proxyPassword: ""
   proxyUsername: ""
 kind: Secret
@@ -1414,7 +1414,7 @@ spec:
     metadata:
       annotations:
         checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
-        checksum/secret: 4c91f059d15ecfed81f3906fb24896c41fde9103a61ace577327d080409423da
+        checksum/secret: 07edf9259ce1c6d595c50929a13b9b06a91655293ac394fe9cead67afe377506
       labels:
         app: docker-registry
         release: flyte-sandbox

diff --git a/docker/sandbox-bundled/manifests/complete.yaml b/docker/sandbox-bundled/manifests/complete.yaml
@@ -797,7 +797,7 @@ type: Opaque
 ---
 apiVersion: v1
 data:
-  haSharedSecret: WGJQZFpzb2ZDSkU5dmJReQ==
+  haSharedSecret: WVZOdERqQktEWWdvM1c0VA==
   proxyPassword: ""
   proxyUsername: ""
 kind: Secret
@@ -1361,7 +1361,7 @@ spec:
     metadata:
       annotations:
         checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
-        checksum/secret: 20145f8b7e37f104163904f86eeb0a46444c157de19f8e675128b04d16598ee4
+        checksum/secret: 32b31fbb2d7281ddbac891c87734245482c5fce18d11c589f1aa38b2bd28f75b
       labels:
         app: docker-registry
         release: flyte-sandbox

diff --git a/docker/sandbox-bundled/manifests/dev.yaml b/docker/sandbox-bundled/manifests/dev.yaml
@@ -499,7 +499,7 @@ metadata:
 ---
 apiVersion: v1
 data:
-  haSharedSecret: R2RwSGJNOERJN2NSWXNQNg==
+  haSharedSecret: SXRvUlE0N1B4eGZqcExXMw==
   proxyPassword: ""
   proxyUsername: ""
 kind: Secret
@@ -934,7 +934,7 @@ spec:
     metadata:
       annotations:
         checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
-        checksum/secret: a110328cf7fce9dfe57fe25438d4902fc3cc661346782bb261c0b6b80fb783d1
+        checksum/secret: a5ded0b6e6f09135a5e9fd69cb5f2a044fcca223bf902a269f6ff1b165ae55a8
       labels:
         app: docker-registry
         release: flyte-sandbox

diff --git a/docs/deployment/agents/airflow.rst b/docs/deployment/agents/airflow.rst
@@ -35,11 +35,6 @@ Specify agent configuration
               - container_array: k8s-array
               - airflow: agent-service
 
-        plugins:
-          agent-service:
-            supportedTaskTypes:
-            - airflow
-
     .. group-tab:: Flyte core
 
       Create a file named ``values-override.yaml`` and add the following configuration to it.
@@ -63,10 +58,6 @@ Specify agent configuration
                   sidecar: sidecar
                   container_array: k8s-array
                   airflow: agent-service
-            plugins:
-              agent-service:
-                supportedTaskTypes:
-                - airflow
 
 
 Upgrade the Flyte Helm release

diff --git a/docs/deployment/agents/bigquery.rst b/docs/deployment/agents/bigquery.rst
@@ -42,11 +42,6 @@ Specify agent configuration
               - container: container
               - container_array: k8s-array
               - bigquery_query_job_task: agent-service
-        
-        plugins:
-          agent-service:
-            supportedTaskTypes:
-            - bigquery_query_job_task
 
     .. group-tab:: Flyte core
 
@@ -71,10 +66,6 @@ Specify agent configuration
                   sidecar: sidecar
                   container_array: k8s-array
                   bigquery_query_job_task: agent-service
-            plugins:
-              agent-service:
-                supportedTaskTypes:
-                - bigquery_query_job_task
 
 Ensure that the propeller has the correct service account for BigQuery.
 

diff --git a/docs/deployment/agents/chatgpt.rst b/docs/deployment/agents/chatgpt.rst
@@ -36,8 +36,6 @@ Specify agent configuration
 
         plugins:
           agent-service:
-            supportedTaskTypes:
-            - chatgpt
             # Configuring the timeout is optional.
             # Tasks like using ChatGPT with a large model might require a longer time, 
             # so we have the option to adjust the timeout setting here.
@@ -70,8 +68,6 @@ Specify agent configuration
                   chatgpt: agent-service
             plugins:
               agent-service:
-                supportedTaskTypes:
-                - chatgpt
                 # Configuring the timeout is optional.
                 # Tasks like using ChatGPT with a large model might require a longer time, 
                 # so we have the option to adjust the timeout setting here.

diff --git a/docs/deployment/agents/databricks.rst b/docs/deployment/agents/databricks.rst
@@ -153,10 +153,6 @@ Specify agent configuration
                 - sidecar
                 - k8s-array
                 - agent-service
-          plugins:
-            agent-service:
-              supportedTaskTypes:
-              - spark
 
       .. group-tab:: Helm chart
 
@@ -176,10 +172,6 @@ Specify agent configuration
                 - container: container
                 - container_array: k8s-array
                 - spark: agent-service
-            plugins:
-              agent-service:
-                supportedTaskTypes:
-                - spark
 
   .. group-tab:: Flyte core
 
@@ -201,10 +193,6 @@ Specify agent configuration
                 sidecar: sidecar
                 container_array: k8s-array
                 spark: agent-service
-          plugins:
-            agent-service:
-              supportedTaskTypes:
-              - spark
 
 Add the Databricks access token
 -------------------------------

diff --git a/docs/deployment/agents/mmcloud.rst b/docs/deployment/agents/mmcloud.rst
@@ -71,8 +71,6 @@ Enable the MMCloud agent by adding the following config to the relevant YAML fil
         mmcloud-agent:
           endpoint: <AGENT_ENDPOINT>
           insecure: true
-      supportedTaskTypes:
-      - mmcloud_task
       agentForTaskTypes:
       - mmcloud_task: mmcloud-agent
 

diff --git a/docs/deployment/agents/openai_batch.rst b/docs/deployment/agents/openai_batch.rst
@@ -32,10 +32,6 @@ Specify agent configuration
               - container: container
               - container_array: k8s-array
               - openai-batch: agent-service
-        plugins:
-          agent-service:
-            supportedTaskTypes:
-            - openai-batch
 
     .. group-tab:: Flyte core
 
@@ -58,10 +54,6 @@ Specify agent configuration
                   sidecar: sidecar
                   container_array: k8s-array
                   openai-batch: agent-service
-            plugins:
-              agent-service:
-                supportedTaskTypes:
-                - openai-batch
 
 Add the OpenAI API token
 ------------------------

diff --git a/docs/deployment/agents/sagemaker_inference.rst b/docs/deployment/agents/sagemaker_inference.rst
@@ -33,11 +33,6 @@ Specify agent configuration
               - container_array: k8s-array
               - boto: agent-service
               - sagemaker-endpoint: agent-service
-        plugins:
-          agent-service:
-            supportedTaskTypes:
-            - boto
-            - sagemaker-endpoint
 
     .. group-tab:: Flyte core
 
@@ -61,11 +56,6 @@ Specify agent configuration
                   container_array: k8s-array
                   boto: agent-service
                   sagemaker-endpoint: agent-service
-            plugins:
-              agent-service:
-                supportedTaskTypes:
-                - boto
-                - sagemaker-endpoint
 
 AWS credentials
 ---------------

diff --git a/docs/deployment/agents/sensor.rst b/docs/deployment/agents/sensor.rst
@@ -69,11 +69,6 @@ Enable the sensor agent by adding the following config to the relevant YAML file
               - container: container
               - container_array: k8s-array
               - sensor: agent-service
-        
-        plugins:
-          agent-service:
-            supportedTaskTypes:
-            - sensor
 
     .. group-tab:: Flyte core
 
@@ -98,10 +93,6 @@ Enable the sensor agent by adding the following config to the relevant YAML file
                   sidecar: sidecar
                   container_array: k8s-array
                   sensor: agent-service
-            plugins:
-              agent-service:
-                supportedTaskTypes:
-                - sensor
 
 
 Upgrade the deployment

diff --git a/docs/deployment/agents/snowflake.rst b/docs/deployment/agents/snowflake.rst
@@ -49,11 +49,6 @@ Specify agent configuration
               - container_array: k8s-array
               - snowflake: agent-service
 
-        plugins:
-          agent-service:
-            supportedTaskTypes:
-            - snowflake
-
     .. group-tab:: Flyte core
 
       Create a file named ``values-override.yaml`` and add the following configuration to it.
@@ -77,10 +72,6 @@ Specify agent configuration
                   sidecar: sidecar
                   container_array: k8s-array
                   snowflake: agent-service
-            plugins:
-              agent-service:
-                supportedTaskTypes:
-                - snowflake
 
 Ensure that the propeller has the correct service account for Snowflake.
 

diff --git a/docs/deployment/configuration/generated/flytepropeller_config.rst b/docs/deployment/configuration/generated/flytepropeller_config.rst
@@ -994,9 +994,6 @@ agent-service (`agent.Config`_)
       Value: 50
     ProjectScopeResourceConstraint:
       Value: 100
-  supportedTaskTypes:
-  - task_type_1
-  - task_type_2
   webApi:
     caching:
       maxSystemFailures: 5

diff --git a/docs/flyte_agents/developing_agents.md b/docs/flyte_agents/developing_agents.md
@@ -197,10 +197,6 @@ you can route particular task requests to designated agent services by adjusting
 ```yaml
  plugins:
    agent-service:
-     supportedTaskTypes:
-       - bigquery_query_job_task
-       - default_task
-       - custom_task
      # By default, all requests will be sent to the default agent.
      defaultAgent:
        endpoint: "dns:///flyteagent.flyte.svc.cluster.local:8000"
@@ -224,4 +220,4 @@ you can route particular task requests to designated agent services by adjusting
      agentForTaskTypes:
        # It will override the default agent for custom_task, which means propeller will send the request to this agent.
        - custom_task: custom_agent
-```
+```