-
Notifications
You must be signed in to change notification settings - Fork 669
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adds Pull request template for flyteidl (#47)
- Loading branch information
Ketan Umare
authored
Mar 9, 2020
1 parent
bf40e32
commit afd9d91
Showing
5 changed files
with
73 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
Pull Request Template | ||
~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
Provides a Pull Request template. | ||
|
||
**To Enable:** | ||
|
||
Add ``lyft/golang_test_targets`` to your ``boilerplate/update.cfg`` file. |
26 changes: 26 additions & 0 deletions
26
flyteidl/boilerplate/lyft/pull_request_template/pull_request_template.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# TL;DR | ||
_Please replace this text with a description of what this PR accomplishes._ | ||
|
||
## Type | ||
- [ ] Bug Fix | ||
- [ ] Feature | ||
- [ ] Plugin | ||
|
||
## Are all requirements met? | ||
|
||
- [ ] Code completed | ||
- [ ] Smoke tested | ||
- [ ] Unit tests added | ||
- [ ] Code documentation added | ||
- [ ] Any pending items have an associated Issue | ||
|
||
## Complete description | ||
_How did you fix the bug, make the feature etc. Link to any design docs etc_ | ||
|
||
## Tracking Issue | ||
https://github.com/lyft/flyte/issues/<number> | ||
|
||
## Follow-up issue | ||
_NA_ | ||
OR | ||
_https://github.com/lyft/flyte/issues/<number>_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
#!/usr/bin/env bash | ||
|
||
# WARNING: THIS FILE IS MANAGED IN THE 'BOILERPLATE' REPO AND COPIED TO OTHER REPOSITORIES. | ||
# ONLY EDIT THIS FILE FROM WITHIN THE 'LYFT/BOILERPLATE' REPOSITORY: | ||
# | ||
# TO OPT OUT OF UPDATES, SEE https://github.com/lyft/boilerplate/blob/master/Readme.rst | ||
|
||
set -e | ||
|
||
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd )" | ||
|
||
cp ${DIR}/pull_request_template.md ${DIR}/../../../pull_request_template.md |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
lyft/golang_test_targets | ||
lyft/golangci_file | ||
lyft/golang_support_tools | ||
lyft/pull_request_template |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# TL;DR | ||
_Please replace this text with a description of what this PR accomplishes._ | ||
|
||
## Type | ||
- [ ] Bug Fix | ||
- [ ] Feature | ||
- [ ] Plugin | ||
|
||
## Are all requirements met? | ||
|
||
- [ ] Code completed | ||
- [ ] Smoke tested | ||
- [ ] Unit tests added | ||
- [ ] Code documentation added | ||
- [ ] Any pending items have an associated Issue | ||
|
||
## Complete description | ||
_How did you fix the bug, make the feature etc. Link to any design docs etc_ | ||
|
||
## Tracking Issue | ||
https://github.com/lyft/flyte/issues/<number> | ||
|
||
## Follow-up issue | ||
_NA_ | ||
OR | ||
_https://github.com/lyft/flyte/issues/<number>_ |