Skip to content

Commit

Permalink
Fix up comment for raw output data (#211)
Browse files Browse the repository at this point in the history
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
  • Loading branch information
Katrina Rogan authored and eapolinario committed Sep 13, 2023
1 parent 56fa673 commit a6788c9
Show file tree
Hide file tree
Showing 23 changed files with 128 additions and 128 deletions.
12 changes: 6 additions & 6 deletions flyteidl/gen/pb-go/flyteidl/service/admin.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -3226,7 +3226,7 @@
},
"output_data": {
"$ref": "#/definitions/coreLiteralMap",
"description": "Raw output metadata produced by this execution."
"description": "Raw output data produced by this execution."
},
"computed_inputs": {
"$ref": "#/definitions/coreLiteralMap",
Expand Down Expand Up @@ -3920,7 +3920,7 @@
},
"output_data": {
"$ref": "#/definitions/coreLiteralMap",
"description": "Raw output metadata produced by this node execution."
"description": "Raw output data produced by this node execution."
},
"phase": {
"$ref": "#/definitions/coreNodeExecutionPhase",
Expand Down Expand Up @@ -4363,7 +4363,7 @@
},
"output_data": {
"$ref": "#/definitions/coreLiteralMap",
"description": "Raw output metadata produced by this task execution."
"description": "Raw output data produced by this task execution."
},
"phase": {
"$ref": "#/definitions/coreTaskExecutionPhase",
Expand Down Expand Up @@ -6174,7 +6174,7 @@
},
"output_data": {
"$ref": "#/definitions/coreLiteralMap",
"description": "Raw output metadata produced by this node execution."
"description": "Raw output data produced by this node execution."
},
"workflow_node_metadata": {
"$ref": "#/definitions/flyteidleventWorkflowNodeMetadata"
Expand Down Expand Up @@ -6285,7 +6285,7 @@
},
"output_data": {
"$ref": "#/definitions/coreLiteralMap",
"description": "Raw output metadata produced by this task execution."
"description": "Raw output data produced by this task execution."
},
"custom_info": {
"$ref": "#/definitions/protobufStruct",
Expand Down Expand Up @@ -6371,7 +6371,7 @@
},
"output_data": {
"$ref": "#/definitions/coreLiteralMap",
"description": "Raw output metadata produced by this workflow execution."
"description": "Raw output data produced by this workflow execution."
}
}
},
Expand Down
12 changes: 6 additions & 6 deletions flyteidl/gen/pb-go/flyteidl/service/flyteadmin/api/swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3115,7 +3115,7 @@ definitions:
\ the user and their supplied cause."
$ref: "#/definitions/adminAbortMetadata"
output_data:
description: "Raw output metadata produced by this execution."
description: "Raw output data produced by this execution."
$ref: "#/definitions/coreLiteralMap"
computed_inputs:
title: "Inputs computed and passed for execution.\ncomputed_inputs depends\
Expand Down Expand Up @@ -5820,7 +5820,7 @@ definitions:
title: "Error information for the Node"
$ref: "#/definitions/coreExecutionError"
output_data:
description: "Raw output metadata produced by this node execution."
description: "Raw output data produced by this node execution."
$ref: "#/definitions/coreLiteralMap"
phase:
description: "The last recorded phase for this node execution."
Expand Down Expand Up @@ -9989,7 +9989,7 @@ definitions:
\ failed."
$ref: "#/definitions/coreExecutionError"
output_data:
description: "Raw output metadata produced by this task execution."
description: "Raw output data produced by this task execution."
$ref: "#/definitions/coreLiteralMap"
phase:
description: "The last recorded phase for this task execution."
Expand Down Expand Up @@ -30794,7 +30794,7 @@ definitions:
title: "Error information for the execution"
$ref: "#/definitions/coreExecutionError"
output_data:
description: "Raw output metadata produced by this node execution."
description: "Raw output data produced by this node execution."
$ref: "#/definitions/coreLiteralMap"
workflow_node_metadata:
$ref: "#/definitions/flyteidleventWorkflowNodeMetadata"
Expand Down Expand Up @@ -30890,7 +30890,7 @@ definitions:
title: "Error information for the execution"
$ref: "#/definitions/coreExecutionError"
output_data:
description: "Raw output metadata produced by this task execution."
description: "Raw output data produced by this task execution."
$ref: "#/definitions/coreLiteralMap"
custom_info:
description: "Custom data that the task plugin sends back. This is extensible\
Expand Down Expand Up @@ -30983,7 +30983,7 @@ definitions:
title: "Error information for the execution"
$ref: "#/definitions/coreExecutionError"
output_data:
description: "Raw output metadata produced by this workflow execution."
description: "Raw output data produced by this workflow execution."
$ref: "#/definitions/coreLiteralMap"
flyteidladminDynamicWorkflowNodeMetadata:
type: "object"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ type AdminExecutionClosure struct {
AbortCause string `json:"abort_cause,omitempty"`
// In the case of a user-specified abort, this will pass along the user and their supplied cause.
AbortMetadata *AdminAbortMetadata `json:"abort_metadata,omitempty"`
// Raw output metadata produced by this execution.
// Raw output data produced by this execution.
OutputData *CoreLiteralMap `json:"output_data,omitempty"`
ComputedInputs *CoreLiteralMap `json:"computed_inputs,omitempty"`
// Most recent recorded phase for the execution.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ type AdminNodeExecutionClosure struct {
// Links to a remotely stored, serialized core.LiteralMap of node execution outputs.
OutputUri string `json:"output_uri,omitempty"`
Error_ *CoreExecutionError `json:"error,omitempty"`
// Raw output metadata produced by this node execution.
// Raw output data produced by this node execution.
OutputData *CoreLiteralMap `json:"output_data,omitempty"`
// The last recorded phase for this node execution.
Phase *CoreNodeExecutionPhase `json:"phase,omitempty"`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ type AdminTaskExecutionClosure struct {
OutputUri string `json:"output_uri,omitempty"`
// Error information for the task execution. Populated if the execution failed.
Error_ *CoreExecutionError `json:"error,omitempty"`
// Raw output metadata produced by this task execution.
// Raw output data produced by this task execution.
OutputData *CoreLiteralMap `json:"output_data,omitempty"`
// The last recorded phase for this task execution.
Phase *CoreTaskExecutionPhase `json:"phase,omitempty"`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ type EventNodeExecutionEvent struct {
// URL to the output of the execution, it encodes all the information including Cloud source provider. ie., s3://...
OutputUri string `json:"output_uri,omitempty"`
Error_ *CoreExecutionError `json:"error,omitempty"`
// Raw output metadata produced by this node execution.
// Raw output data produced by this node execution.
OutputData *CoreLiteralMap `json:"output_data,omitempty"`
WorkflowNodeMetadata *FlyteidleventWorkflowNodeMetadata `json:"workflow_node_metadata,omitempty"`
TaskNodeMetadata *FlyteidleventTaskNodeMetadata `json:"task_node_metadata,omitempty"`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ type EventTaskExecutionEvent struct {
// URI to the output of the execution, it will be in a format that encodes all the information including Cloud source provider. ie., s3://...
OutputUri string `json:"output_uri,omitempty"`
Error_ *CoreExecutionError `json:"error,omitempty"`
// Raw output metadata produced by this task execution.
// Raw output data produced by this task execution.
OutputData *CoreLiteralMap `json:"output_data,omitempty"`
// Custom data that the task plugin sends back. This is extensible to allow various plugins in the system.
CustomInfo *ProtobufStruct `json:"custom_info,omitempty"`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ type EventWorkflowExecutionEvent struct {
// URL to the output of the execution, it encodes all the information including Cloud source provider. ie., s3://...
OutputUri string `json:"output_uri,omitempty"`
Error_ *CoreExecutionError `json:"error,omitempty"`
// Raw output metadata produced by this workflow execution.
// Raw output data produced by this workflow execution.
OutputData *CoreLiteralMap `json:"output_data,omitempty"`
}
4 changes: 2 additions & 2 deletions flyteidl/gen/pb-go/flyteidl/service/openapi.go

Large diffs are not rendered by default.

30 changes: 15 additions & 15 deletions flyteidl/gen/pb-java/flyteidl/admin/ExecutionOuterClass.java

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit a6788c9

Please sign in to comment.