Skip to content

Commit

Permalink
Additional execution properties as matchable entities. (#253)
Browse files Browse the repository at this point in the history
* proposal

Signed-off-by: Katrina Rogan <[email protected]>

* comments

Signed-off-by: Katrina Rogan <[email protected]>

* Fixed the import and updated tooling

Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Updating the golang version to 1.7

Signed-off-by: Prafulla Mahindrakar <[email protected]>

* feedback

Signed-off-by: Prafulla Mahindrakar <[email protected]>

Co-authored-by: Prafulla Mahindrakar <[email protected]>
  • Loading branch information
katrogan and pmahindrakar-oss authored Mar 25, 2022
1 parent fab9084 commit 9cba092
Show file tree
Hide file tree
Showing 18 changed files with 2,651 additions and 241 deletions.
4 changes: 2 additions & 2 deletions flyteidl/.github/workflows/verification.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ jobs:
with:
fetch-depth: "0"
- name: Unit Tests
uses: cedrickring/golang-action@1.6.0
uses: cedrickring/golang-action@1.7.0
env:
GO111MODULE: "on"
with:
args: make install && make test_unit
- name: Lint
uses: cedrickring/golang-action@1.6.0
uses: cedrickring/golang-action@1.7.0
env:
GO111MODULE: "on"
with:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ set -e
# In the format of "<cli>:<package>" or ":<package>" if no cli
tools=(
"github.com/vektra/mockery/cmd/mockery"
"github.com/flyteorg/flytestdlib/cli/pflags"
"github.com/golangci/golangci-lint/cmd/golangci-lint"
"github.com/flyteorg/flytestdlib/cli/pflags@latest"
"github.com/golangci/golangci-lint/cmd/golangci-lint@latest"
"github.com/alvaroloes/enumer"
"github.com/pseudomuto/protoc-gen-doc/cmd/protoc-gen-doc"
)
Expand Down
4 changes: 2 additions & 2 deletions flyteidl/clients/go/admin/config_flags.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions flyteidl/clients/go/admin/config_flags_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

446 changes: 381 additions & 65 deletions flyteidl/gen/pb-cpp/flyteidl/admin/matchable_resource.pb.cc

Large diffs are not rendered by default.

222 changes: 222 additions & 0 deletions flyteidl/gen/pb-cpp/flyteidl/admin/matchable_resource.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 9cba092

Please sign in to comment.