Skip to content

Commit

Permalink
add arrayNodeHandler comments
Browse files Browse the repository at this point in the history
Signed-off-by: Future-Outlier <[email protected]>
  • Loading branch information
Future-Outlier committed Oct 30, 2024
1 parent 182f5e1 commit 856e606
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions flytepropeller/pkg/controller/nodes/attr_path_resolver.go
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,9 @@ func resolveAttrPathInBinary(nodeID string, binaryIDL *core.Binary, bindAttrPath
}
}

// if currVal is list, convert it to literal collection
// This is for map task handling
// In arrayNodeHandler, the resolved value should be a literal collection.
// If the current value is already a collection, convert it to a literal collection.
// This conversion does not affect how Flytekit processes the resolved value.
if collection, ok := currVal.([]any); ok {
literals := make([]*core.Literal, len(collection))
for i, v := range collection {
Expand Down

0 comments on commit 856e606

Please sign in to comment.