Remove protoc-gen-validate (#4643)

* Stop producing the protoc-gen-validate code in go and python Signed-off-by: Eduardo Apolinario <[email protected]> * Remove python files Signed-off-by: Eduardo Apolinario <[email protected]> * Remove pb.validate.go files Signed-off-by: Eduardo Apolinario <[email protected]> * Add datacatalog files Signed-off-by: Eduardo Apolinario <[email protected]> * Remove uses of validate in flyteadmin Signed-off-by: Eduardo Apolinario <[email protected]> * Remove validate from artifacts and cloudevents Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
flyteorg · Dec 27, 2023 · 81ce71e · 81ce71e
1 parent 4a7c3c0
commit 81ce71e
Show file tree

Hide file tree

Showing 62 changed files with 23 additions and 37,866 deletions.
diff --git a/flyteadmin/pkg/manager/impl/validation/execution_validator.go b/flyteadmin/pkg/manager/impl/validation/execution_validator.go
@@ -68,11 +68,6 @@ func ValidateExecutionRequest(ctx context.Context, request admin.ExecutionCreate
 			return err
 		}
 	}
-	// TODO: Remove redundant validation with the rest of the method.
-	// This final call to validating the request ensures the notification types are expected.
-	if err := request.Validate(); err != nil {
-		return err
-	}
 	return nil
 }
 

diff --git a/flyteadmin/pkg/manager/impl/validation/launch_plan_validator.go b/flyteadmin/pkg/manager/impl/validation/launch_plan_validator.go
@@ -61,11 +61,6 @@ func ValidateLaunchPlan(ctx context.Context,
 			return err
 		}
 	}
-	// TODO: Remove redundant validation that occurs with launch plan and the validate method for the message.
-	// Ensure the notification types are validated.
-	if err := request.Validate(); err != nil {
-		return err
-	}
 	return nil
 }