-
Notifications
You must be signed in to change notification settings - Fork 669
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Signed-off-by: Andrew Dye <[email protected]>
- Loading branch information
1 parent
c3fba7d
commit 77dc89e
Showing
1 changed file
with
14 additions
and
47 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,51 +1,18 @@ | ||
| ## Tracking issue | ||
| _https://github.com/flyteorg/flyte/issues/<number>_ | ||
| ## Overview | ||
| *TODO: Provide a brief description of the feature or issue, and then summarize the changes in this PR. For larger changes make sure to callout high level design decisions. Reference relevant [design docs](https://unionai.atlassian.net/wiki/spaces/ENG/pages/78512174/Design+Review) or [Jira issues](https://unionai.atlassian.net/issues/?jql=created%20%3E%3D%20-30d%20order%20by%20created%20DESC).* | ||
|
|
||
| <!-- If your PR fixes an open issue, use `Closes #999` to link your PR with the issue. #999 stands for the issue number you are fixing --> | ||
| ## Test Plan | ||
| *TODO: Summarize tests added, integration tests run, or other steps you took to validate this change. Include (or link to) relevant test output or screenshots.* | ||
|
|
||
| <!-- Remove this section if not applicable --> | ||
| ## Rollout Plan (if applicable) | ||
| *TODO: Describe any deployment or compatibility considerations for rolling out this change. | ||
|
|
||
| <!-- Example: Closes #31 --> | ||
| ## Jira Issue | ||
| https://unionai.atlassian.net/browse/<project-number> | ||
|
|
||
| ## Why are the changes needed? | ||
|
|
||
| <!-- | ||
| Please clarify why the changes are needed. For instance, | ||
| 1. If you propose a new API, clarify the use case for a new API. | ||
| 2. If you fix a bug, you can clarify why it is a bug. | ||
| --> | ||
|
|
||
| ## What changes were proposed in this pull request? | ||
|
|
||
| <!-- | ||
| Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. | ||
| If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below. | ||
| 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers. | ||
| 2. If there is design documentation, please add the link. | ||
| --> | ||
|
|
||
| ## How was this patch tested? | ||
|
|
||
| <!-- | ||
| If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. | ||
| If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. | ||
| If tests were not added, please describe why they were not added and/or why it was difficult to add. | ||
| --> | ||
|
|
||
| ### Setup process | ||
|
|
||
| ### Screenshots | ||
|
|
||
| ## Check all the applicable boxes <!-- Follow the above conventions to check the box --> | ||
|
|
||
| - [ ] I updated the documentation accordingly. | ||
| - [ ] All new and existing tests passed. | ||
| - [ ] All commits are signed-off. | ||
|
|
||
| ## Related PRs | ||
|
|
||
| <!-- Add related pull requests for reviewers to check --> | ||
|
|
||
| ## Docs link | ||
|
|
||
| <!-- Add documentation link built by CI jobs here, and specify the changed place --> | ||
| ## Checklist | ||
| * [ ] Added tests | ||
| * [ ] Ran a deploy dry run and shared the terraform plan | ||
| * [ ] Added logging and metrics | ||
| * [ ] Updated [dashboards](https://unionai.grafana.net/dashboards) and [alerts](https://unionai.grafana.net/alerting/list) | ||
| * [ ] Updated documentation |