Skip to content

Commit

Permalink
Remove flyteadmin config options which now have defaults (#917)
Browse files Browse the repository at this point in the history
Signed-off-by: Haytham Abuelfutuh <[email protected]>
  • Loading branch information
Katrina Rogan authored and EngHabu committed May 28, 2021
1 parent 6db935a commit 76e94e5
Show file tree
Hide file tree
Showing 19 changed files with 52 additions and 130 deletions.
33 changes: 9 additions & 24 deletions deployment/eks/flyte_generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8142,13 +8142,6 @@ data:
logger:
show-source: true
level: 2
remote_data.yaml: |
remoteData:
# TODO change this to match the region of the s3 bucket
region: "us-west-2"
scheme: aws
signedUrls:
durationMinutes: 3
server.yaml: |
server:
httpPort: 8088
Expand All @@ -8164,14 +8157,6 @@ data:
- "Content-Type"
flyteadmin:
roleNameKey: "iam.amazonaws.com/role"
profilerPort: 10254
metricsScope: "flyte:"
metadataStoragePrefix:
- "metadata"
- "admin"
eventVersion: 1
testing:
host: http://flyteadmin
storage.yaml: |
storage:
type: stow
Expand Down Expand Up @@ -8203,7 +8188,7 @@ data:
gpu: 1
kind: ConfigMap
metadata:
name: flyte-admin-config-4ft85ftt4m
name: flyte-admin-config-ddg9df67hb
namespace: flyte
---
apiVersion: v1
Expand Down Expand Up @@ -8701,15 +8686,15 @@ spec:
labels:
app: flyteadmin
app.kubernetes.io/name: flyteadmin
app.kubernetes.io/version: 0.3.38
app.kubernetes.io/version: 0.4.13
spec:
containers:
- command:
- flyteadmin
- --config
- /etc/flyte/config/*.yaml
- serve
image: ghcr.io/flyteorg/flyteadmin:v0.4.7
image: ghcr.io/flyteorg/flyteadmin:v0.4.13
imagePullPolicy: IfNotPresent
name: flyteadmin
ports:
Expand Down Expand Up @@ -8754,7 +8739,7 @@ spec:
- /etc/flyte/config/*.yaml
- migrate
- run
image: ghcr.io/flyteorg/flyteadmin:v0.4.7
image: ghcr.io/flyteorg/flyteadmin:v0.4.13
imagePullPolicy: IfNotPresent
name: run-migrations
volumeMounts:
Expand All @@ -8771,7 +8756,7 @@ spec:
- flytesnacks
- flytetester
- flyteexamples
image: ghcr.io/flyteorg/flyteadmin:v0.4.7
image: ghcr.io/flyteorg/flyteadmin:v0.4.13
imagePullPolicy: IfNotPresent
name: seed-projects
volumeMounts:
Expand All @@ -8785,7 +8770,7 @@ spec:
- /etc/flyte/config/*.yaml
- clusterresource
- sync
image: ghcr.io/flyteorg/flyteadmin:v0.4.7
image: ghcr.io/flyteorg/flyteadmin:v0.4.13
imagePullPolicy: IfNotPresent
name: sync-cluster-resources
volumeMounts:
Expand All @@ -8800,7 +8785,7 @@ spec:
- emptyDir: {}
name: shared-data
- configMap:
name: flyte-admin-config-4ft85ftt4m
name: flyte-admin-config-ddg9df67hb
name: config-volume
- configMap:
name: clusterresource-template-tkdkkt4cb5
Expand Down Expand Up @@ -9063,7 +9048,7 @@ spec:
- /etc/flyte/config/*.yaml
- clusterresource
- sync
image: ghcr.io/flyteorg/flyteadmin:v0.4.7
image: ghcr.io/flyteorg/flyteadmin:v0.4.13
imagePullPolicy: IfNotPresent
name: sync-cluster-resources
volumeMounts:
Expand All @@ -9080,7 +9065,7 @@ spec:
name: clusterresource-template-tkdkkt4cb5
name: resource-templates
- configMap:
name: flyte-admin-config-4ft85ftt4m
name: flyte-admin-config-ddg9df67hb
name: config-volume
- name: db-pass
secret:
Expand Down
29 changes: 9 additions & 20 deletions deployment/gcp/flyte_generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8139,9 +8139,6 @@ data:
logger:
show-source: true
level: 2
remote_data.yaml: |
remoteData:
scheme: "gcp"
server.yaml: |
server:
httpPort: 8088
Expand All @@ -8157,14 +8154,6 @@ data:
- "Content-Type"
flyteadmin:
roleNameKey: "iam.amazonaws.com/role"
profilerPort: 10254
metricsScope: "flyte:"
metadataStoragePrefix:
- "metadata"
- "admin"
eventVersion: 1
testing:
host: http://flyteadmin
storage.yaml: |
storage:
type: stow
Expand Down Expand Up @@ -8198,7 +8187,7 @@ data:
gpu: 1
kind: ConfigMap
metadata:
name: flyte-admin-config-7k2dmcb4tg
name: flyte-admin-config-mhdft5gck2
namespace: flyte
---
apiVersion: v1
Expand Down Expand Up @@ -8739,15 +8728,15 @@ spec:
labels:
app: flyteadmin
app.kubernetes.io/name: flyteadmin
app.kubernetes.io/version: 0.3.38
app.kubernetes.io/version: 0.4.13
spec:
containers:
- command:
- flyteadmin
- --config
- /etc/flyte/config/*.yaml
- serve
image: ghcr.io/flyteorg/flyteadmin:v0.4.7
image: ghcr.io/flyteorg/flyteadmin:v0.4.13
imagePullPolicy: IfNotPresent
name: flyteadmin
ports:
Expand Down Expand Up @@ -8792,7 +8781,7 @@ spec:
- /etc/flyte/config/*.yaml
- migrate
- run
image: ghcr.io/flyteorg/flyteadmin:v0.4.7
image: ghcr.io/flyteorg/flyteadmin:v0.4.13
imagePullPolicy: IfNotPresent
name: run-migrations
volumeMounts:
Expand All @@ -8809,7 +8798,7 @@ spec:
- flytesnacks
- flytetester
- flyteexamples
image: ghcr.io/flyteorg/flyteadmin:v0.4.7
image: ghcr.io/flyteorg/flyteadmin:v0.4.13
imagePullPolicy: IfNotPresent
name: seed-projects
volumeMounts:
Expand All @@ -8823,7 +8812,7 @@ spec:
- /etc/flyte/config/*.yaml
- clusterresource
- sync
image: ghcr.io/flyteorg/flyteadmin:v0.4.7
image: ghcr.io/flyteorg/flyteadmin:v0.4.13
imagePullPolicy: IfNotPresent
name: sync-cluster-resources
volumeMounts:
Expand All @@ -8838,7 +8827,7 @@ spec:
- emptyDir: {}
name: shared-data
- configMap:
name: flyte-admin-config-7k2dmcb4tg
name: flyte-admin-config-mhdft5gck2
name: config-volume
- configMap:
name: clusterresource-template-tkdkkt4cb5
Expand Down Expand Up @@ -9101,7 +9090,7 @@ spec:
- /etc/flyte/config/*.yaml
- clusterresource
- sync
image: ghcr.io/flyteorg/flyteadmin:v0.4.7
image: ghcr.io/flyteorg/flyteadmin:v0.4.13
imagePullPolicy: IfNotPresent
name: sync-cluster-resources
volumeMounts:
Expand All @@ -9118,7 +9107,7 @@ spec:
name: clusterresource-template-tkdkkt4cb5
name: resource-templates
- configMap:
name: flyte-admin-config-7k2dmcb4tg
name: flyte-admin-config-mhdft5gck2
name: config-volume
- name: db-pass
secret:
Expand Down
32 changes: 9 additions & 23 deletions deployment/sandbox/flyte_generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2152,12 +2152,6 @@ data:
logger:
show-source: true
level: 2
remote_data.yaml: |
remoteData:
region: "us-east-1"
scheme: "local"
signedUrls:
durationMinutes: 3
server.yaml: |
server:
httpPort: 8088
Expand All @@ -2173,14 +2167,6 @@ data:
- "Content-Type"
flyteadmin:
roleNameKey: "iam.amazonaws.com/role"
profilerPort: 10254
metricsScope: "flyte:"
metadataStoragePrefix:
- "metadata"
- "admin"
eventVersion: 1
testing:
host: http://flyteadmin
storage.yaml: |+
storage:
type: minio
Expand All @@ -2206,7 +2192,7 @@ data:
gpu: 1
kind: ConfigMap
metadata:
name: flyte-admin-config-5b5g7785h8
name: flyte-admin-config-8kt2hhhb92
namespace: flyte
---
apiVersion: v1
Expand Down Expand Up @@ -2843,15 +2829,15 @@ spec:
labels:
app: flyteadmin
app.kubernetes.io/name: flyteadmin
app.kubernetes.io/version: 0.3.38
app.kubernetes.io/version: 0.4.13
spec:
containers:
- command:
- flyteadmin
- --config
- /etc/flyte/config/*.yaml
- serve
image: ghcr.io/flyteorg/flyteadmin:v0.4.7
image: ghcr.io/flyteorg/flyteadmin:v0.4.13
imagePullPolicy: IfNotPresent
name: flyteadmin
ports:
Expand Down Expand Up @@ -2902,7 +2888,7 @@ spec:
- /etc/flyte/config/*.yaml
- migrate
- run
image: ghcr.io/flyteorg/flyteadmin:v0.4.7
image: ghcr.io/flyteorg/flyteadmin:v0.4.13
imagePullPolicy: IfNotPresent
name: run-migrations
volumeMounts:
Expand All @@ -2918,7 +2904,7 @@ spec:
- seed-projects
- flytesnacks
- flyteexamples
image: ghcr.io/flyteorg/flyteadmin:v0.4.7
image: ghcr.io/flyteorg/flyteadmin:v0.4.13
imagePullPolicy: IfNotPresent
name: seed-projects
volumeMounts:
Expand All @@ -2932,7 +2918,7 @@ spec:
- /etc/flyte/config/*.yaml
- clusterresource
- sync
image: ghcr.io/flyteorg/flyteadmin:v0.4.7
image: ghcr.io/flyteorg/flyteadmin:v0.4.13
imagePullPolicy: IfNotPresent
name: sync-cluster-resources
volumeMounts:
Expand All @@ -2950,7 +2936,7 @@ spec:
- emptyDir: {}
name: shared-data
- configMap:
name: flyte-admin-config-5b5g7785h8
name: flyte-admin-config-8kt2hhhb92
name: config-volume
- name: db-pass
secret:
Expand Down Expand Up @@ -3337,7 +3323,7 @@ spec:
- /etc/flyte/config/*.yaml
- clusterresource
- sync
image: ghcr.io/flyteorg/flyteadmin:v0.4.7
image: ghcr.io/flyteorg/flyteadmin:v0.4.13
imagePullPolicy: IfNotPresent
name: sync-cluster-resources
volumeMounts:
Expand All @@ -3354,7 +3340,7 @@ spec:
name: clusterresource-template-dtg8ff28mt
name: resource-templates
- configMap:
name: flyte-admin-config-5b5g7785h8
name: flyte-admin-config-8kt2hhhb92
name: config-volume
- name: db-pass
secret:
Expand Down
Loading

0 comments on commit 76e94e5

Please sign in to comment.