Skip to content

Commit

Permalink
Expose clusterName as flytepropeller config (#2177)
Browse files Browse the repository at this point in the history
* Expose clusterName as flytepropeller config

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Add changelog

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Regenerate helm

Signed-off-by: Haytham Abuelfutuh <[email protected]>
  • Loading branch information
EngHabu authored Feb 16, 2022
1 parent 2311632 commit 5cb780d
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG/CHANGELOG-v0.19.3-b2.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# 0.19.3-b2 Change Log

## System
* Allow clusterName to be passed to flytepropeller through the Values.yaml file.
1 change: 1 addition & 0 deletions charts/flyte-core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ helm install gateway bitnami/contour -n flyte
| flyteconsole.tolerations | list | `[]` | tolerations for Flyteconsole deployment |
| flytepropeller.affinity | object | `{}` | affinity for Flytepropeller deployment |
| flytepropeller.cacheSizeMbs | int | `0` | |
| flytepropeller.clusterName | string | `""` | Defines the cluster name used in events sent to Admin |
| flytepropeller.configPath | string | `"/etc/flyte/config/*.yaml"` | Default regex string for searching configuration files |
| flytepropeller.enabled | bool | `true` | |
| flytepropeller.extraArgs | object | `{}` | Appends extra command line arguments to the main command |
Expand Down
4 changes: 4 additions & 0 deletions charts/flyte-core/templates/propeller/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ spec:
{{- end }}
- --config
- {{ .Values.flytepropeller.configPath }}
{{- with .Values.flytepropeller.clusterName }}
- --propeller.cluster-id
- {{ tpl (toYaml .) $ }}
{{- end -}}
{{- with .Values.flytepropeller.extraArgs }}
{{- tpl (toYaml $) . | nindent 6 }}
{{- end }}
Expand Down
2 changes: 2 additions & 0 deletions charts/flyte-core/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,8 @@ flytepropeller:
affinity: {}
# -- Appends extra command line arguments to the main command
extraArgs: {}
# -- Defines the cluster name used in events sent to Admin
clusterName: ""

#
# FLYTECONSOLE SETTINGS
Expand Down

0 comments on commit 5cb780d

Please sign in to comment.